All of lore.kernel.org
 help / color / mirror / Atom feed
From: Graeme Russ <gruss@tss-engineering.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] Enable booting of mx28 without battery
Date: Fri, 23 Jan 2015 13:58:16 +1100	[thread overview]
Message-ID: <54C1B8C8.7020106@tss-engineering.com> (raw)
In-Reply-To: <CAOMZO5ALWECLtnZxmbgRz7q36Z8waXSHuXfOTJF2YvCYUwMJ9g@mail.gmail.com>

Hi Fabio,

On 22/01/15 23:42, Fabio Estevam wrote:
> Hi Graeme,
>
> On Wed, Jan 21, 2015 at 9:55 AM, Graeme Russ <gruss@tss-engineering.com> wrote:
>> Section 4.1.2 of Freescale Application Note AN4199 describes the
>> configuration required to operate the mx28 from a 5V source without a
>> battery. This patch implements the changes to the Freescale bootlets
>> which allow this configuration to properly boot the mx28 processor
>>
>> Signed-off-by: Graeme Russ <gruss@tss-engineering.com>
>> ---
>>
>>   arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 190 +++++++++++++++++++++++++++-
>>   doc/README.mxs                              |  10 ++
>
> Damien posted today a new version of this patch in the imx community,
> which is a lot simpler.
>
> Could you please try it?

I've taken a look at it, but decided to leave this patch as-is. Here is 
what I wrote on the Freescale forum:

~~~~
I'm going to keep my U-Boot patch mostly as-is for a few reasons:
- The patch disables battery voltage measurement when there is no battery
- The patch disables all code paths relating to booting from battery
- The power block configuration is based primarily on the Fressscale 
bootlets which I think should be retained unless we can come up with 
some pretty clear and convincing arguments as to why an alternative 
approach is better

I think there is scope for some refactoring of the power block setup 
code in U-Boot, but for now I think it best to leave it as close to the 
bootlet code sequence as practical
~~~~

Regards,


Graeme

  parent reply	other threads:[~2015-01-23  2:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 11:55 [U-Boot] [PATCH 0/5] Add support for G2C1 mx28 board (which has no battery) Graeme Russ
2015-01-21 11:55 ` [U-Boot] [PATCH 1/5] Add debug output to mx29 SPL source files Graeme Russ
2015-01-21 20:49   ` Fabio Estevam
2015-01-21 23:24   ` Marek Vasut
2015-01-22  4:24     ` Graeme Russ
2015-01-21 11:55 ` [U-Boot] [PATCH 2/5] Enable booting of mx28 without battery Graeme Russ
2015-01-21 12:03   ` Graeme Russ
2015-01-21 21:08     ` Fabio Estevam
2015-01-21 23:27   ` Marek Vasut
2015-01-23  0:58     ` Graeme Russ
2015-01-22 12:42   ` Fabio Estevam
2015-01-22 13:51     ` Marek Vasut
2015-01-23  2:58     ` Graeme Russ [this message]
2015-01-23  3:01       ` Fabio Estevam
2015-01-23  3:27         ` Graeme Russ
2015-01-23  3:49           ` Fabio Estevam
2015-01-23  4:14             ` Graeme Russ
     [not found]               ` <DB3PR05MB252F1D6A1521E87599A5991CB360@DB3PR05MB252.eurprd05.prod.outlook.com>
2015-01-23  8:11                 ` Graeme Russ
2015-01-23 13:01                   ` Stefano Babic
2015-01-21 11:55 ` [U-Boot] [PATCH 3/5] Add 'Wait for JTAG user' if booted in JTAG mode Graeme Russ
2015-01-21 15:35   ` Stefan Roese
2015-01-21 11:55 ` [U-Boot] [PATCH 4/5] Move PLL power-up from power init to memory init Graeme Russ
2015-01-21 23:33   ` Marek Vasut
2015-01-21 11:55 ` [U-Boot] [PATCH 5/5] Add support for ReachTech G2C1 board Graeme Russ
2015-01-21 20:53   ` Fabio Estevam
2015-01-21 23:03     ` Marek Vasut
2015-01-22  4:21       ` Graeme Russ
2015-01-21 23:36   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C1B8C8.7020106@tss-engineering.com \
    --to=gruss@tss-engineering.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.