From: Sinan Akman <sinan@writeme.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] removing bit reversing for SCFG in immap_ls102xa.h
Date: Fri, 23 Jan 2015 02:11:24 -0500 [thread overview]
Message-ID: <54C1F41C.3090305@writeme.com> (raw)
Hi Alison
I was just testing out ls1021atwr board with NOR
boot using rcw_1000.bin.
I noticed that Ethernet is not working.
In ls1021atwr.c we have :
out_be32(&scfg->etsecdmamcr, SCFG_ETSECDMAMCR_LE_BD_FR);
out_be32(&scfg->etsecmcr, SCFG_ETSECCMCR_GE2_CLK125);
In your earlier commit c207ff612903389f8b32e377fe32be43e6efd8f7
you removed the bit reversing around this but those defines are not
in big-endian. By setting bit reversing before those lines as
before makes Ethernet working.
Could you please take a look at this. Should we reverse
your commit since we are accessing SCFG registers directly
in the board specific files ?
Regards
Sinan Akman
next reply other threads:[~2015-01-23 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 7:11 Sinan Akman [this message]
2015-01-23 9:06 ` [U-Boot] removing bit reversing for SCFG in immap_ls102xa.h Huan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C1F41C.3090305@writeme.com \
--to=sinan@writeme.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.