From: Hans Verkuil <hverkuil@xs4all.nl>
To: Shuah Khan <shuahkh@osg.samsung.com>,
m.chehab@samsung.com, hans.verkuil@cisco.com,
dheitmueller@kernellabs.com, prabhakar.csengg@gmail.com,
sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
ttmesterr@gmail.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: au0828 - convert to use videobuf2
Date: Fri, 23 Jan 2015 10:50:10 +0100 [thread overview]
Message-ID: <54C21952.7010602@xs4all.nl> (raw)
In-Reply-To: <1421970125-8169-1-git-send-email-shuahkh@osg.samsung.com>
Hi Shuah,
On 01/23/2015 12:42 AM, Shuah Khan wrote:
> Convert au0828 to use videobuf2. Tested with NTSC.
> Tested video and vbi devices with xawtv, tvtime,
> and vlc. Ran v4l2-compliance to ensure there are
> no regressions. video now has no failures and vbi
> has 3 fewer failures.
>
> video before:
> test VIDIOC_G_FMT: FAIL 3 failures
> Total: 72, Succeeded: 69, Failed: 3, Warnings: 0
>
> Video after:
> Total: 72, Succeeded: 72, Failed: 0, Warnings: 18
>
> vbi before:
> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL
> test VIDIOC_EXPBUF: FAIL
> test USERPTR: FAIL
> Total: 72, Succeeded: 66, Failed: 6, Warnings: 0
>
> vbi after:
> test VIDIOC_QUERYCAP: FAIL
> test MMAP: FAIL
> Total: 78, Succeeded: 75, Failed: 3, Warnings: 0
There shouldn't be any fails for VBI. That really needs to be fixed.
Esp. the QUERYCAP fail should be easy to fix.
BTW, can you paste the full v4l2-compliance output next time? That's
more informative than just these summaries.
Regards,
Hans
next prev parent reply other threads:[~2015-01-23 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 23:42 [PATCH v4] media: au0828 - convert to use videobuf2 Shuah Khan
2015-01-23 9:50 ` Hans Verkuil [this message]
2015-01-23 15:00 ` Shuah Khan
2015-01-23 19:17 ` Shuah Khan
2015-01-23 19:36 ` Shuah Khan
2015-01-23 19:49 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C21952.7010602@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dheitmueller@kernellabs.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkh@osg.samsung.com \
--cc=ttmesterr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.