All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control
Date: Fri, 23 Jan 2015 22:48:55 +0900	[thread overview]
Message-ID: <54C25147.5000708@samsung.com> (raw)
In-Reply-To: <CCA5BE08-02BB-425E-B508-C207B998AC20@konsulko.com>

Dear Pantelis.

On 01/23/2015 10:44 PM, Pantelis Antoniou wrote:
> Hi Jaehoon,
> 
>> On Jan 23, 2015, at 15:43 , Jaehoon Chung <jh80.chung@gmail.com> wrote:
>>
>> Hi
>>
>> Could you check this patch?
>>
> 
> Ugh, sorry missed this; did it end up assigned at patchwork to me?

Updated. :)

Best Regards,
Jaehoon Chung
> 
> The patch is obviously correct.
> 
>> Best Regards,
>> Jaehoon Chung
>>
> 
> Regards
> 
> ? Pantelis
> 
>> On 01/14/2015 05:37 PM, Jaehoon Chung wrote:
>>> If mode is not DDR-mode, then it needs to clear it.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> ---
>>> drivers/mmc/dw_mmc.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
>>> index b18c75d..76fa0b0 100644
>>> --- a/drivers/mmc/dw_mmc.c
>>> +++ b/drivers/mmc/dw_mmc.c
>>> @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
>>> 	if (mmc->ddr_mode)
>>> 		regs |= DWMCI_DDR_MODE;
>>> 	else
>>> -		regs &= DWMCI_DDR_MODE;
>>> +		regs &= ~DWMCI_DDR_MODE;
>>>
>>> 	dwmci_writel(host, DWMCI_UHS_REG, regs);
>>>
>>>
>>
> 
> 

  reply	other threads:[~2015-01-23 13:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  8:37 [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control Jaehoon Chung
2015-01-23 13:43 ` Jaehoon Chung
2015-01-23 13:44   ` Pantelis Antoniou
2015-01-23 13:48     ` Jaehoon Chung [this message]
2015-02-23 17:36 ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C25147.5000708@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.