From: Steve Dickson <SteveD@redhat.com>
To: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>,
linux-nfs@vger.kernel.org
Subject: Re: nfs-utils/idmapd: use of private define breaks with libevent-2.1.x
Date: Fri, 23 Jan 2015 09:03:51 -0500 [thread overview]
Message-ID: <54C254C7.8090507@RedHat.com> (raw)
In-Reply-To: <pan.2015.01.17.18.25.17@googlemail.com>
On 01/17/2015 01:25 PM, Holger Hoffstätte wrote:
>
> Hello,
>
> The Gentoo community has found a problem with the current release of
> nfs-utils, where idmapd uses a not strictly private, yet strongly
> discouraged #define.
>
> Bug description with proposed patch:
> https://bugs.gentoo.org/show_bug.cgi?id=446374
Committed...
steved.
>
> The code in question:
> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=utils/idmapd/idmapd.c;hb=HEAD#l719
>
> According to:
> https://github.com/libevent/libevent/blob/master/include/event2/event_struct.h
>
> which says:
> "No field declared in this file should be used directly in user code."
>
> using EVLIST_INIT directly is bound to break. This seems to be a leftover
> from legacy code.
>
> A simple fix is attached to the bugzilla above and just calls the
> proper public API, which is functionally equivalent to the bit check.
>
> Would be nice to see this in 1.3.2. :)
>
> Thanks!
>
> Holger
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-01-23 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 18:25 nfs-utils/idmapd: use of private define breaks with libevent-2.1.x Holger Hoffstätte
2015-01-23 14:03 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C254C7.8090507@RedHat.com \
--to=steved@redhat.com \
--cc=holger.hoffstaette@googlemail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.