All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, amulya.lokesha@emc.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: vhdx - force FileOffsetMB field to '0' for certain block states
Date: Fri, 23 Jan 2015 09:47:50 -0500	[thread overview]
Message-ID: <54C25F16.4050606@redhat.com> (raw)
In-Reply-To: <a9fe92f53f07e6ab1693811e4312c0d1e958500b.1421787566.git.jcody@redhat.com>

On 2015-01-20 at 16:01, Jeff Cody wrote:
> The v1.0.0 spec calls out PAYLOAD_BLOCK_ZERO FileOffsetMB field as being
> 'reserved'.  In practice, this means that Hyper-V will fail to read a
> disk image with PAYLOAD_BLOCK_ZERO block states with a FileOffsetMB
> value other than 0.
>
> The other states that indicate a block that is not there
> (PAYLOAD_BLOCK_UNDEFINED, PAYLOAD_BLOCK_NOT_PRESENT,
>   PAYLOAD_BLOCK_UNMAPPED) have multiple options for what FileOffsetMB may
> be set to, and '0' is explicitly called out as an option.
>
> For all the above states, we will also just set the FileOffsetMB value
> to 0.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>   block/vhdx.c | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)

Thanks, applied to my block tree:

https://github.com/XanClic/qemu/commits/block

      parent reply	other threads:[~2015-01-23 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 21:01 [Qemu-devel] [PATCH] block: vhdx - force FileOffsetMB field to '0' for certain block states Jeff Cody
2015-01-22 17:28 ` Max Reitz
2015-01-23 14:47 ` Max Reitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C25F16.4050606@redhat.com \
    --to=mreitz@redhat.com \
    --cc=amulya.lokesha@emc.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.