From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YEiyp-0001mp-83 for mharc-grub-devel@gnu.org; Fri, 23 Jan 2015 13:29:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEiyl-0001ev-6H for grub-devel@gnu.org; Fri, 23 Jan 2015 13:29:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEiyk-0003YE-Bx for grub-devel@gnu.org; Fri, 23 Jan 2015 13:29:11 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:63653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEiyk-0003YA-3p for grub-devel@gnu.org; Fri, 23 Jan 2015 13:29:10 -0500 Received: by mail-wi0-f173.google.com with SMTP id r20so4772709wiv.0 for ; Fri, 23 Jan 2015 10:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=niPQppeSX2UHy1Wbd26LeEYRVrEFbubNzNoou6VhG8E=; b=l9DnmnOm6FbGusmwGbOPNCteguYhahEZ/bQn0PKWajT6Ui1lE5s3Nf/vGPGz2A5lsb Ys+jj5Q+nP2oBL+421UFZ3iSP74xLFV1pWjCx8+vU1NcMIs25O/rFbLLSnPxkhONUwK5 QMRI6G9Ra3WJ7HglVVKnAGgAp7TFZ0/GOD5c79WVG5K1hR15+ajtnrZQs4mr0wSy2UNo TDfIsmXsUC+INkcNbagENQKCT37wmaKoQv6R5f/kSJ3MbfG2VcmIQzo6/nbLrJUQ6Y7N wb+fhG4Aqe2164ttin5ffEb/XErENl/53Prhlskp9/JhZB2/CF+O/aCelxuhat7sfdfV MCOg== X-Received: by 10.180.76.133 with SMTP id k5mr6293257wiw.30.1422037749441; Fri, 23 Jan 2015 10:29:09 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:c6e9:2fff:fe57:96ed? ([2620:0:105f:fd00:c6e9:2fff:fe57:96ed]) by mx.google.com with ESMTPSA id bo3sm3176450wjb.44.2015.01.23.10.29.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jan 2015 10:29:08 -0800 (PST) Message-ID: <54C292F3.2020102@gmail.com> Date: Fri, 23 Jan 2015 19:29:07 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Andrei Borzenkov Subject: Re: Does grub-mkrescue support UEFI hybrid USB/DVD images? References: <54C16AD2.7090808@pcbsd.org> <54C17680.9080804@gmail.com> <54C21824.6060407@gmail.com> <20150123205839.1af3ce51@opensuse.site> In-Reply-To: <20150123205839.1af3ce51@opensuse.site> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lvPmik6HWViCHkoC4lc41PHI6RjWijORR" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22d Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 18:29:12 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lvPmik6HWViCHkoC4lc41PHI6RjWijORR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > But returning (hd0,gpt2) would also be wrong here - ESP on CD image is > empty, we need to somehow jump from ESP to full ISO image. >=20 Returning hd0,gpt2 is fine. By convention ()/file refers to parent disk of whatever root partition is (as opposed to /file). So just including part_gpt in core should be enough. But perhaps we should put my patch as well to increase reliability. Consider scenario of installing on disk with gpt and apt and using apt partitions. GRUB will properly detect that it needs part_apple but part_gpt is not needed to access partition. Most of the install tools specify partition explicitly, so having partition is non-critical. Having disk on the hand is critical. @Kris: Please try (after removing the other patch) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index e719839..e02340f 100644 --- a/util/grub-mkrescue.c +++ b/util/grub-mkrescue.c @@ -653,6 +653,9 @@ main (int argc, char *argv[]) char *efiimgfat; grub_install_mkdir_p (efidir_efi_boot); + grub_install_push_module ("part_gpt"); + grub_install_push_module ("part_msdos"); + imgname =3D grub_util_path_concat (2, efidir_efi_boot, "bootia64.e= fi"); make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_IA64_EFI, "ia64-efi", imgname); free (imgname); @@ -713,6 +716,8 @@ main (int argc, char *argv[]) free (efiimgfat); free (efidir_efi); free (efidir); + grub_install_pop_module (); + grub_install_pop_module (); } grub_install_push_module ("part_apple"); --lvPmik6HWViCHkoC4lc41PHI6RjWijORR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlTCkvMACgkQmBXlbbo5nOtV7gD/VZV7zuU3m4EnzN+kInrFWJUJ +E5+R55wRAHaeSJ+3bQBAJun4ozIBI+fn1zmud57pn7G2EgPYLv1jzugn8pmnURW =liKP -----END PGP SIGNATURE----- --lvPmik6HWViCHkoC4lc41PHI6RjWijORR--