All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Gordon <david.s.gordon@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/atomic-helpers: Recover full cursor plane behaviour
Date: Fri, 23 Jan 2015 19:33:23 +0000	[thread overview]
Message-ID: <54C2A203.2000503@intel.com> (raw)
In-Reply-To: <20150121174553.GP10113@phenom.ffwll.local>

On 21/01/15 17:45, Daniel Vetter wrote:
> On Wed, Jan 21, 2015 at 04:59:08PM +0000, Dave Gordon wrote:
>> On 20/01/15 22:09, Daniel Vetter wrote:
>>> Cursor plane updates have historically been fully async and mutliple
>>> updates batched together for the next vsync. And userspace relies upon
>>> that. Since implementing a full queue of async atomic updates is a bit
>>> of work lets just recover the cursor specific behaviour with a hint
>>> flag and some hacks to drop the vblank wait.
>>
>> I tried this patch 4/4 alone, and then the whole set of four, on
>> -internal, which is currently also suffering from the laggy-mouse
>> problem, and it didn't fix the issue. Was it expected that this patchset
>> would cure that problem, or is there something else required?
> 
> Nah, since I didn't bother to hack up the plane transitional helpers that
> we're currently using. The laggy cursor /should/ be mostly fixed though
> with
> 
> commit d99b70ce7d73d78a88311453ccdd0fa0a670dd50
> Author: Matt Roper <matthew.d.roper@intel.com>
> Date:   Mon Jan 19 08:31:49 2015 -0800
> 
>     drm/plane-helper: Skip prepare_fb/cleanup_fb when newfb==oldfb
> 
> Can you pls double-check that you have that patch?
> 
> This patch series here is only effective one Matt Roper's latest series to
> switch to atomic proper has landed. But if there's a need I can extend it
> a bit to the plane transitional helpers.
> -Daniel

Thanks Daniel, the -internal baseline that Alex & I are working with was
based on -nightly of 2015y-01m-08d-11h-43m-40s and therefore didn't have
that patch. Adding that seems to fix all the mouse lag :)

.Dave.


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-01-23 19:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 22:09 [PATCH 1/4] drm: Add standardized boolean props Daniel Vetter
2015-01-20 22:09 ` [PATCH 2/4] drm/atomic: Add drm_crtc_state->active Daniel Vetter
2015-01-21 21:59   ` Rob Clark
2015-01-22  7:04   ` [PATCH] " Daniel Vetter
2015-01-22  9:03     ` Thierry Reding
2015-01-20 22:09 ` [PATCH 3/4] drm/atomic-helper: add connector->dpms() implementation Daniel Vetter
2015-01-20 22:09 ` [PATCH 4/4] drm/atomic-helpers: Recover full cursor plane behaviour Daniel Vetter
2015-01-21  8:32   ` shuang.he
2015-01-21 16:59   ` Dave Gordon
2015-01-21 17:45     ` Daniel Vetter
2015-01-23 19:33       ` Dave Gordon [this message]
2015-01-22  8:44   ` Thierry Reding
2015-01-21  7:47 ` [PATCH] drm: Add standardized boolean props Daniel Vetter
2015-01-21 21:38   ` Rob Clark
2015-01-22  8:52   ` Thierry Reding
2015-01-22 17:32   ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C2A203.2000503@intel.com \
    --to=david.s.gordon@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.