All of lore.kernel.org
 help / color / mirror / Atom feed
From: Loic Dachary <loic@dachary.org>
To: "Miyamae, Takeshi" <miyamae.takeshi@jp.fujitsu.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>,
	"Shiozawa, Kensuke" <shiozawa.kennsu@jp.fujitsu.com>,
	"Nakao, Takanori" <nakao.takanori@jp.fujitsu.com>,
	"Paul Von-Stamwitz (PVonStamwitz@us.fujitsu.com)"
	<PVonStamwitz@us.fujitsu.com>,
	"Kaga, Yoshihiro" <y-kaga@jp.fujitsu.com>,
	"Kawaguchi, Shotaro" <kawaguchi.s@jp.fujitsu.com>
Subject: Re: mSHEC r33 release
Date: Sat, 24 Jan 2015 00:39:56 +0100	[thread overview]
Message-ID: <54C2DBCC.4050207@dachary.org> (raw)
In-Reply-To: <870DE8DBB716524BAE51B2D499EC81E40AA64D91@g01jpexmbyt24>

[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]

Hi,

Since the SHEC plugin depends on the jerasure plugin, it would be simpler if it loaded it instead of including it. The main problem with the current inclusion is that it does not compile any SIMD acceleration code and loses the benefit of optimization when the CPU can provide it. 

There are two ways out of this 

a) add to the SHEC plugin the same selection that jerasure has (in the Makefile and with something like http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/jerasure/ErasureCodePluginSelectJerasure.cc

b) compile jerasure as a convenience library that can be included by both the jerasure and SHEC plugin.

The LRC plugin loads the jerasure plugin but the SHEC plugin cannot do the same because the standard API at http://workbench.dachary.org/ceph/ceph/blob/master/src/erasure-code/ErasureCodeInterface.h is not enough.

Note that this is not a blocker for the inclusion of the plugin and can be done afterwards.

Cheers

On 23/01/2015 15:30, Miyamae, Takeshi wrote:
> Hi Loic,
> 
> We have released mSHEC r33 just now.
> 
> https://github.com/t-miyamae/ceph
> 
> NOTABLE CHANGES
>   - ensure thread safety
>   - support generator matrix cache (added ErasureCodeShecTableCache.cc)
>   - refer to the shared jerasure 2.0 library
>   - improve verification of return code in test codes
>   - add test code for verifying thread safety (added TestErasureCodeShec_thread.cc)
> 
> LIMITATION
>   - There are still lots of minor problems in test codes.
>     We will fix it by 1/26(mon).
> 
> Best regards,
> Takeshi Miyamae
> 
> N�����r��y���b�X��ǧv�^�)޺{.n�+���z�]z���{ay�\x1dʇڙ�,j\a��f���h���z�\x1e�w���\f���j:+v���w�j�m����\a����zZ+�����ݢj"��!tml=
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2015-01-23 23:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 14:30 mSHEC r33 release Miyamae, Takeshi
2015-01-23 14:39 ` Loic Dachary
2015-01-24  9:09   ` Miyamae, Takeshi
2015-01-24 16:20     ` Loic Dachary
2015-01-26  2:21       ` Miyamae, Takeshi
2015-01-26  2:43         ` Miyamae, Takeshi
2015-01-23 20:51 ` Loic Dachary
2015-01-23 23:39 ` Loic Dachary [this message]
2015-01-24  8:13   ` Miyamae, Takeshi
2015-01-24 16:21     ` Loic Dachary
2015-01-23 23:59 ` Loic Dachary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C2DBCC.4050207@dachary.org \
    --to=loic@dachary.org \
    --cc=PVonStamwitz@us.fujitsu.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=kawaguchi.s@jp.fujitsu.com \
    --cc=miyamae.takeshi@jp.fujitsu.com \
    --cc=nakao.takanori@jp.fujitsu.com \
    --cc=shiozawa.kennsu@jp.fujitsu.com \
    --cc=y-kaga@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.