From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH 12/14] xen-blkback: safely unmap grants in
 case they are still in use
Date: Sat, 24 Jan 2015 09:57:02 +0100
Message-ID: <54C35E5E.3050508@citrix.com>
References: <1421682692-20628-1-git-send-email-david.vrabel@citrix.com>	<1421682692-20628-13-git-send-email-david.vrabel@citrix.com>	<54C25B2F.9090205@citrix.com>
	<54C260BA.7060506@citrix.com> <54C26D00.8000306@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1YEwX2-0003Wd-M2
	for xen-devel@lists.xenproject.org; Sat, 24 Jan 2015 08:57:28 +0000
In-Reply-To: <54C26D00.8000306@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>, Jenny Herbert <jennifer.herbert@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 23/01/15 a les 16.47, Roger Pau Monn=E9 ha escrit:
> This should be fixed to at least be (which is still not fully correct,
> but it's better):
> =

> pages +=3D invcount;
> num -=3D invcount;

Forget about this chunk above, it is plain wrong and would make the loop
endless if there are persistent grants in the set of grants to unmap.

Roger.