Re: [PATCH v2 1/1] x86: Add Isolated Memory Regions for Quark X1000

["Bryan O'Donoghue" <pure.logic@nexus-software.ie>]

On 24/01/15 21:56, Bryan O'Donoghue wrote:
>>>> +
>>>> +                      if ((imr_to_phys(imr.addr_lo) == base) &&
>>>> +                          (imr_to_phys(imr.addr_hi) == max)) {
>>> I think we need to take care of the size that has been fix-up here ...
>>>
>>>> +                              found = 1;
>>>> +                              reg = i;
>>
>> According to your comment this line becomes redundant.
>>
>
> Ah but I still think though.

"Ah but I still think *I'll keep* that though

:)

> We eventually do an imr_write(reg, &imr); which I think reads better
> than imr_write(i, &imr);
>
> --
> BOD