Re: [PATCH] crypto: aesni - make driver-gcm-aes-aesni helper a proper aead alg

[Tadeusz Struk <tadeusz.struk@intel.com>]

Hi Stephan,
On 01/25/2015 12:58 AM, Stephan Mueller wrote:
>> +static int rfc4106_set_key(struct crypto_aead *parent, const u8 *key,
>> > +			   unsigned int key_len)
>> >  {
>> >  	struct aesni_rfc4106_gcm_ctx *ctx = aesni_rfc4106_gcm_ctx_get(parent);
>> >  	struct crypto_aead *cryptd_child = cryptd_aead_child(ctx->cryptd_tfm);
>> > +	struct aesni_rfc4106_gcm_ctx *child_ctx =
>> > +		aesni_rfc4106_gcm_ctx_get(cryptd_child);
>> > +	int ret;
>> > 
>> > +	ret = common_rfc4106_set_key(parent, key, key_len);
> Shouldn't that one be crypto_aead_setkey, i.e using the regular crypto API 
> instead of internal calls?
> 

No, I don't think so. I think that would create an infinite loop.

>> +static int rfc4106_set_authsize(struct crypto_aead *parent,
>> > +				unsigned int authsize)
>> > +{
>> > +	struct aesni_rfc4106_gcm_ctx *ctx = aesni_rfc4106_gcm_ctx_get(parent);
>> > +	struct crypto_aead *cryptd_child = cryptd_aead_child(ctx->cryptd_tfm);
>> > +	int ret;
>> > +
>> > +	ret = common_rfc4106_set_authsize(parent, authsize);
> Same here, shouldn't that one be crypto_aead_setauthsize?
> 

Same here.

Thanks,
Tadeusz