From: Peter Hurley <peter@hurleysoftware.com>
To: Johannes Thumshirn <johannes.thumshirn@men.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] tty: serial: men_z135_uart: Fix driver for changes in hardware
Date: Sun, 25 Jan 2015 16:17:27 -0500 [thread overview]
Message-ID: <54C55D67.8060503@hurleysoftware.com> (raw)
In-Reply-To: <1421649881-2275-1-git-send-email-johannes.thumshirn@men.de>
On 01/19/2015 01:44 AM, Johannes Thumshirn wrote:
> 16z135 IP Core has changed so the driver needs to be updated to respect
> these changes. The following changes have been made:
>
> * Don't invert the 16z135 modem status register when reading.
> * Add module parameter to configure the (baud rate dependent) RX timeout.
> Character timeout in seconds = (timeout_reg * baud_reg * 4)/freq_reg.
> * Enable the handling of UART core's automatic flow control feature.
> When AFE is active disable generation of modem status IRQs.
> * Rework the handling of IRQs to be conform with newer FPGA versions and
> take precautions not to miss an interrupt because of the destructive read
> of the IIR register.
> * Correct men_z135_handle_modem_status(), MSR is stat_reg[15:8] not
> stat_reg[7:0]
> * Correct calling of uart_handle_{dcd,cts}_change()
> * Reset CLOCAL when CRTSCTS is set
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
prev parent reply other threads:[~2015-01-25 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 6:44 [PATCH v5] tty: serial: men_z135_uart: Fix driver for changes in hardware Johannes Thumshirn
2015-01-19 6:44 ` Johannes Thumshirn
2015-01-25 21:17 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C55D67.8060503@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes.thumshirn@men.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.