All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate a nonsense goto
Date: Mon, 26 Jan 2015 21:00:37 +0000	[thread overview]
Message-ID: <54C6AAF5.6010409@redhat.com> (raw)
In-Reply-To: <1822797357.13595283.1421943115036.JavaMail.zimbra@redhat.com>

Hi,

Now in the -nmw git tree. Thanks,

Steve.

On 22/01/15 16:11, Bob Peterson wrote:
> Hi,
>
> This patch just removes a goto that did nothing.
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 9054002..73c72253 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -543,10 +543,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
>   	}
>   
>   	error = gfs2_dir_add(&dip->i_inode, name, ip, da);
> -	if (error)
> -		goto fail_end_trans;
>   
> -fail_end_trans:
>   	gfs2_trans_end(sdp);
>   fail_ipreserv:
>   	gfs2_inplace_release(dip);
>



      reply	other threads:[~2015-01-26 21:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1232858145.13594871.1421943047836.JavaMail.zimbra@redhat.com>
2015-01-22 16:11 ` [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate a nonsense goto Bob Peterson
2015-01-26 21:00   ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C6AAF5.6010409@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.