From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: adis16400: Fix sign extension
Date: Mon, 26 Jan 2015 21:07:45 +0000 [thread overview]
Message-ID: <54C6ACA1.6000909@kernel.org> (raw)
In-Reply-To: <54C20CA5.7050204@metafoo.de>
On 23/01/15 08:56, Lars-Peter Clausen wrote:
> On 01/23/2015 12:34 AM, Rasmus Villemoes wrote:
>> The intention is obviously to sign-extend a 12 bit quantity. But
>> because of C's promotion rules, the assignment is equivalent to "val16
>> &= 0xfff;". Use the proper API for this.
>>
>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
Applied to the fixes-togreg branch of iio.git and cc'd to stable.
next prev parent reply other threads:[~2015-01-26 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 23:34 [PATCH] iio: imu: adis16400: Fix sign extension Rasmus Villemoes
2015-01-23 8:56 ` Lars-Peter Clausen
2015-01-26 21:07 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-30 8:30 [patch] " Dan Carpenter
2015-01-30 8:30 ` Dan Carpenter
2015-01-30 8:34 ` Lars-Peter Clausen
2015-01-30 8:34 ` Lars-Peter Clausen
2015-01-30 9:22 ` Dan Carpenter
2015-01-30 9:22 ` Dan Carpenter
2015-01-30 9:31 ` Rasmus Villemoes
2015-01-30 9:31 ` Rasmus Villemoes
2015-01-30 10:23 ` Dan Carpenter
2015-01-30 10:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C6ACA1.6000909@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.