From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFreN-0005LU-UU for qemu-devel@nongnu.org; Mon, 26 Jan 2015 16:56:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFreI-00075v-UZ for qemu-devel@nongnu.org; Mon, 26 Jan 2015 16:56:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFreI-00075V-MJ for qemu-devel@nongnu.org; Mon, 26 Jan 2015 16:56:46 -0500 Message-ID: <54C6B819.7010102@redhat.com> Date: Mon, 26 Jan 2015 14:56:41 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422284444-12529-1-git-send-email-mreitz@redhat.com> <1422284444-12529-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1422284444-12529-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UxOfexs3Dra7qK7Gh0hNL2nLEWUdc2g8n" Subject: Re: [Qemu-devel] [PATCH v3 02/14] block: Add blk_new_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , Stefano Stabellini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UxOfexs3Dra7qK7Gh0hNL2nLEWUdc2g8n Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 08:00 AM, Max Reitz wrote: > blk_new_with_bs() creates a BlockBackend with an empty BlockDriverState= > attached to it. Empty BDSs are not nice, therefore add an alternative > function which combines blk_new_with_bs() with bdrv_open(). >=20 > Note: In contrast to bdrv_open() which takes a BlockDriver parameter, > blk_new_open() does not take such a parameter. This is because > bdrv_open() opens a BlockDriverState, therefore it is naturally to be s/naturally/natural/ > able to set the BlockDriver for that BDS. The fact that bdrv_open() can= > open more than a single BDS is merely some form of a byproduct. >=20 > blk_new_open() on the other hand is intended to be used to create a > whole tree of BlockDriverStates. Therefore, setting a single BlockDrive= r > does not make much sense. Instead, the drivers to be used for each of > the nodes must be configured through the "options" QDict; including the= > driver of the root BDS. >=20 > Signed-off-by: Max Reitz > --- > block/block-backend.c | 34 ++++++++++++++++++++++++++++++++++= > include/sysemu/block-backend.h | 3 +++ > 2 files changed, 37 insertions(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UxOfexs3Dra7qK7Gh0hNL2nLEWUdc2g8n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUxrgaAAoJEKeha0olJ0Nqqy4H/0mn2u7eBd9wPs2q3vL253Wt 2c38ZxWKBbffYq1wtleN4pHfVbNnLS/gteNFzTOGcSSKpNLWeV84mbjC+MQmOW1S yzca2C7+3V0DrWbn0mAsSxPbhMW99W3/3ycYuNpi2MK8ccx37AUX3bT60WJWJSxV WCkrGuoWGDQU7Yc02oYNwr0TK392A/hhHCKYQub5+8rXZ1JZ+r4DLZhr6XifVWsm FTYcciALUSWPNtPXXqJiQUw3eUpHUFAiGzz3zB3JXtgrI3pRCcE3f0yf986mgejE KFS3UfKTnF1DZYQZUloDwJ0YsQ/8YcURyJUkDeb8sTTpW64uxiIFcb1sXMsaglg= =86ZP -----END PGP SIGNATURE----- --UxOfexs3Dra7qK7Gh0hNL2nLEWUdc2g8n--