From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFsIG-0007WZ-7c for qemu-devel@nongnu.org; Mon, 26 Jan 2015 17:38:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFsIB-0004IS-8M for qemu-devel@nongnu.org; Mon, 26 Jan 2015 17:38:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFsIB-0004IO-11 for qemu-devel@nongnu.org; Mon, 26 Jan 2015 17:37:59 -0500 Message-ID: <54C6C1C1.9070104@redhat.com> Date: Mon, 26 Jan 2015 15:37:53 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422284444-12529-1-git-send-email-mreitz@redhat.com> <1422284444-12529-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1422284444-12529-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DDKViPEF7Ee5mDHV3A95pgqItxv7cKPni" Subject: Re: [Qemu-devel] [PATCH v3 03/14] blockdev: Use blk_new_open() in blockdev_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , Stefano Stabellini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DDKViPEF7Ee5mDHV3A95pgqItxv7cKPni Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 08:00 AM, Max Reitz wrote: > Due to different error propagation, this breaks tests 051 and 087; fix > their output. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 92 +++++++++++++++++++++-----------------= -------- > tests/qemu-iotests/051.out | 60 +++++++++++++++--------------- > tests/qemu-iotests/087.out | 8 ++-- > 3 files changed, 76 insertions(+), 84 deletions(-) > =20 > Testing: -drive file=3DTEST_DIR/t.qcow2,driver=3Draw,format=3Dqcow2 > -QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,driver=3Draw,format=3Dqcow2:= could not open disk image TEST_DIR/t.qcow2: Driver specified twice > +QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,driver=3Draw,format=3Dqcow2:= Cannot specify both 'driver' and 'format' Is it possible to specify driver=3Dqcow2,format=3Dqcow2? Should it be? Either way, are we testing the outcome of that? (that is, there is a difference between two competing options, and two spellings of the same option - I could go for either rejecting the duplication, or for allowing it when the two are the same, whichever is easier, but would like to make sure it is tested so we know if we change our minds later whether we are risking a regression). > =20 > =20 > =3D=3D=3D Specifying both an option and its legacy alias =3D=3D=3D > @@ -323,13 +323,13 @@ QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,readonl= y=3Don,read-only=3Doff: 'read-only' a > =3D=3D=3D Parsing protocol from file name =3D=3D=3D > =20 > Testing: -hda foo:bar > -QEMU_PROG: -hda foo:bar: could not open disk image foo:bar: Unknown pr= otocol > +QEMU_PROG: -hda foo:bar: Unknown protocol Not the fault of this patch, but can this error message be improved? Even 'Unknown protocol: foo' would read better. All of the other shorter error messages still seem to read fine, and the decrease in verbosity could be argued as a feature. So overall, I'm fine with this patch. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DDKViPEF7Ee5mDHV3A95pgqItxv7cKPni Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUxsHBAAoJEKeha0olJ0NqoEYH/1iCVpPBxU0SgjTj2aWm0bXr 52YWLDw0KrJR5BT4rVnc0R5Vxvw8lnFjixXY9xvWE3jmOLT45/5etmb6p9i1maNi Y77Xq/bv3LAxqkoEYPlbTYWgWrgU9kzKBGDZJ1+Shyq8XvAGKyRylqzVLbCjGdXn 1eyCJK4fPdSLpAsyHF02y+vbJ1raIcPJZVbwJI7vd/ZOFs6JGoBzV6fS+l9kb+h8 NGFGjPHFQVGl7B90mZaCVHOZEiZVNhGzxDF5MFEJ46FnmGSnEFEHAdvzxKMfogye r5AXDYsndQAecVvns6fwUVOqRfijD3+fh927nP1srnsm43au3fAZ36Y7+f58hoo= =b/oA -----END PGP SIGNATURE----- --DDKViPEF7Ee5mDHV3A95pgqItxv7cKPni--