All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Bittencourt <gbitten@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH -rt] rtmutex: enable deadlock detection in the ww_mutex_lock functions
Date: Tue, 27 Jan 2015 03:53:30 -0200	[thread overview]
Message-ID: <54C727DA.4040601@gmail.com> (raw)

According the ww-mutex-design.txt documentation,  the ww_mutex_lock_interruptible and ww_mutex_lock functions should return -EDEADLK when faced with a deadlock. To do so, the flag detect_deadlock in the rt_mutex_slowlock calls should be enabled. This patch corrects potential deadlocks when running PREEMPT_RT with nouveau driver.

Kernel v3.14-rt

Signed-off-by: Gustavo Bittencourt<gbitten@gmail.com>
---
  kernel/locking/rtmutex.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 6c40660..3f6ef91 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -1965,7 +1965,7 @@ __ww_mutex_lock_interruptible(struct ww_mutex *lock, struct ww_acquire_ctx *ww_c
  	might_sleep();
  
  	mutex_acquire(&lock->base.dep_map, 0, 0,_RET_IP_);
-	ret = rt_mutex_slowlock(&lock->base.lock, TASK_INTERRUPTIBLE, NULL, 0, ww_ctx);
+	ret = rt_mutex_slowlock(&lock->base.lock, TASK_INTERRUPTIBLE, NULL, 1, ww_ctx);
  	if (ret)
  		mutex_release(&lock->base.dep_map, 1,_RET_IP_);
  	else if (!ret && ww_ctx->acquired > 1)
@@ -1984,7 +1984,7 @@ __ww_mutex_lock(struct ww_mutex *lock, struct ww_acquire_ctx *ww_ctx)
  
  	mutex_acquire_nest(&lock->base.dep_map, 0, 0, &ww_ctx->dep_map,
  			_RET_IP_);
-	ret = rt_mutex_slowlock(&lock->base.lock, TASK_UNINTERRUPTIBLE, NULL, 0, ww_ctx);
+	ret = rt_mutex_slowlock(&lock->base.lock, TASK_UNINTERRUPTIBLE, NULL, 1, ww_ctx);
  	if (ret)
  		mutex_release(&lock->base.dep_map, 1,_RET_IP_);
  	else if (!ret && ww_ctx->acquired > 1)
-- 1.9.1


             reply	other threads:[~2015-01-27  5:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  5:53 Gustavo Bittencourt [this message]
2015-01-27  6:49 ` [PATCH -rt] rtmutex: enable deadlock detection in the ww_mutex_lock functions Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C727DA.4040601@gmail.com \
    --to=gbitten@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.