From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 28/29] ArmVirtualizationPkg/VirtFdtDxe: wire up XenBusDxe to "xen, xen" DT node Date: Tue, 27 Jan 2015 11:57:35 +0000 Message-ID: <54C77D2F.6080502@linaro.org> References: <1422299011-2409-1-git-send-email-ard.biesheuvel@linaro.org> <1422299011-2409-29-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422299011-2409-29-git-send-email-ard.biesheuvel@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ard Biesheuvel , edk2-devel@lists.sourceforge.net, lersek@redhat.com, olivier.martin@arm.com, roy.franz@linaro.org, leif.lindholm@linaro.org, stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, anthony.perard@citrix.com, christoffer.dall@linaro.org, xen-devel@lists.xen.org, ilias.biris@linaro.org List-Id: xen-devel@lists.xenproject.org Hi Ard, On 26/01/15 19:03, Ard Biesheuvel wrote: > typedef struct { > @@ -66,6 +68,7 @@ STATIC CONST PROPERTY CompatibleProperties[] = { > { PropertyTypePsci, "arm,psci-0.2" }, > { PropertyTypeFwCfg, "qemu,fw-cfg-mmio" }, > { PropertyTypeGicV3, "arm,gic-v3" }, > + { PropertyTypeXen, "xen,xen" }, > { PropertyTypeUnknown, "" } > }; > > @@ -332,6 +335,26 @@ InitializeVirtFdtDxe ( > } > break; > > + case PropertyTypeXen: > + ASSERT (Len == 16); > + I would not assume that the reg property is always 16 bytes (8 bytes for the address and 8 bytes for the size). We may decide to change it in the future. That's why #address-cells and #size-cells exist in the DT. But it looks like that the other part of the code in this function always assume a fixed length. I guess we could live with it. I would add a comment explaining this restriction. Regards, -- Julien Grall