All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2] spl: Change debug to printf for "Unsupported boot-device"
Date: Tue, 27 Jan 2015 15:38:37 +0100	[thread overview]
Message-ID: <54C7A2ED.8090409@denx.de> (raw)
In-Reply-To: <20150127142253.GJ10826@bill-the-cat>

On 27.01.2015 15:22, Tom Rini wrote:
>>>> We had the problem on an AM33xx platform, that SPL detected an
>>>> unsupported boot-device. But since this message is a debug message
>>>> it took a bit of time to really know, where the hangup in SPL
>>>> resulted from. So let's change this debug message to a printf
>>>> and also print the detected boot-device that is not supported.
>>>> This makes debugging of such cases much easier.
>>>>
>>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>>> Cc: Wolfgang Denk <wd@denx.de>
>>>> Cc: Tom Rini <trini@ti.com>
>>>> Acked-by: Heiko Schocher <hs@denx.de>
>>>
>>> Applied to u-boot/master, thanks!
>>>
>>>
>> This patch is causing problem on Microblaze because SPL exceed 4k limit.
>> It is only one printf which is called in entire SPL that's why this should
>> be solved a little bit differently.
>
> OK, but for clarity you need and are using both
> CONFIG_SPL_SERIAL_SUPPORT and CONFIG_SPL_LIBCOMMON_SUPPORT because
> you're using puts but not printf, yes?

Right. If this is the case (only puts usage on Microblaze), then its 
perhaps best that I change this line to puts as well. Okay?

Thanks,
Stefan

  reply	other threads:[~2015-01-27 14:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 18:03 [U-Boot] [PATCH v2] spl: Change debug to printf for "Unsupported boot-device" Stefan Roese
2014-11-13  6:52 ` Heiko Schocher
2014-11-24 22:10 ` [U-Boot] [U-Boot, " Tom Rini
2015-01-27 13:43   ` Michal Simek
2015-01-27 14:08     ` Stefan Roese
2015-01-27 14:22     ` Tom Rini
2015-01-27 14:38       ` Stefan Roese [this message]
2015-01-27 14:40         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C7A2ED.8090409@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.