From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG7L3-0008R2-5C for qemu-devel@nongnu.org; Tue, 27 Jan 2015 09:42:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG7Ky-0006ll-Um for qemu-devel@nongnu.org; Tue, 27 Jan 2015 09:41:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG7Ky-0006lX-NR for qemu-devel@nongnu.org; Tue, 27 Jan 2015 09:41:52 -0500 Message-ID: <54C7A36B.7080708@redhat.com> Date: Tue, 27 Jan 2015 15:40:43 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1421857131-18539-1-git-send-email-agraf@suse.de> <1421857131-18539-2-git-send-email-agraf@suse.de> <20150127142457.GA9335@redhat.com> In-Reply-To: <20150127142457.GA9335@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Peter Maydell Cc: Rob Herring , Ard Biesheuvel , QEMU Developers , Claudio Fontana , Alvise Rigo , Stuart Yoder , Alexander Graf On 27/01/2015 15:24, Michael S. Tsirkin wrote: > I suspect this is not the only device that leaks memory now. > Paolo? It should be, this is a bug. Commit d8d95814609e89e5438a3318a647ec322fc4ff16 missed this place due to a rebase error. (I can tell it's a rebase error because I have the fixed patch in a private branch). Paolo Author: Paolo Bonzini Date: Wed Jun 11 12:42:01 2014 +0200 memory: convert memory_region_destroy to object_unparent Explicitly call object_unparent in the few places where we will re-create the memory region. If the memory region is simply being destroyed as part of device teardown, let QOM handle it. Signed-off-by: Paolo Bonzini