From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 04/12] xen/arm: device: Rename device_type into device_match Date: Tue, 27 Jan 2015 16:09:27 +0000 Message-ID: <54C7B837.9000408@linaro.org> References: <1421418247-30068-1-git-send-email-julien.grall@linaro.org> <1421418247-30068-5-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YG8iD-0005R0-CV for xen-devel@lists.xenproject.org; Tue, 27 Jan 2015 16:09:57 +0000 Received: by mail-wi0-f176.google.com with SMTP id em10so5914239wid.3 for ; Tue, 27 Jan 2015 08:09:55 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 27/01/15 16:05, Stefano Stabellini wrote: > On Fri, 16 Jan 2015, Julien Grall wrote: >> This enum was used for matching a specific device and not to get the >> type of device. >> >> Hence the name device_type will be used for another purpose later. >> >> Signed-off-by: Julien Grall > > If you really want to rename this field, please find a more descriptive > name for it. device_match doesn't really tell me what we are trying to > match against. At least device_type would tell me that we are matching > against the type. I was struggling to find a correct name. For me device_type refers to PCI/platform device. And it will be used this way later. Maybe device_category? Regards, -- Julien Grall