From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YG90W-00037y-Mb for mharc-grub-devel@gnu.org; Tue, 27 Jan 2015 11:28:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG90S-00035F-0J for grub-devel@gnu.org; Tue, 27 Jan 2015 11:28:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG90Q-0007fh-Q4 for grub-devel@gnu.org; Tue, 27 Jan 2015 11:28:47 -0500 Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:38078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG90Q-0007fF-Ir for grub-devel@gnu.org; Tue, 27 Jan 2015 11:28:46 -0500 Received: by mail-wg0-f51.google.com with SMTP id k14so15698337wgh.10 for ; Tue, 27 Jan 2015 08:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=JnbFLLUd7k9K65ONzlen2tCDz8KytTjdOYiE8NUmPoI=; b=MfBwbwWwkGF+idj16WM3qwF7Nrs7lPDrSdVaGNZ7gWexSDUkQX7mKVAwuL24zom/hf vPxGD+dpgIlPYFudiACOX+6Rx22MVZFtZEFp39jVZbvbe1f6g+otcCNNZSyDQIkqQ4Xv sKmz9B+FF2+jsNfCaPVK7H/HS404/FEaCT2hfSIDV3JzEfLeXp/XKwcn0/nu1OdhaYx7 ueujVdVoHUJh0TjZvt2wLJgWgEz+AJFF2FXOsn1JCXRpQxLiKN2ykv1w2plT1kNC+SDz 1LnEp8BOSI+iYe66XrUjeZ0sUEr/PA+lCxQodZnaAbKASgF8QPWP2K5gjgm39RPOLeBh J+ng== X-Received: by 10.180.95.97 with SMTP id dj1mr7400509wib.43.1422376125264; Tue, 27 Jan 2015 08:28:45 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:c6e9:2fff:fe57:96ed? ([2620:0:105f:fd00:c6e9:2fff:fe57:96ed]) by mx.google.com with ESMTPSA id j1sm2457073wjw.25.2015.01.27.08.28.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 08:28:44 -0800 (PST) Message-ID: <54C7BCBB.2040806@gmail.com> Date: Tue, 27 Jan 2015 17:28:43 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64. References: <54C65779.3070500@gmail.com> <20150126195050.13f6969a@opensuse.site> In-Reply-To: <20150126195050.13f6969a@opensuse.site> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nhB1cmLJxAh8xefLLrt4T7Mp2cRxj8HCP" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 16:28:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nhB1cmLJxAh8xefLLrt4T7Mp2cRxj8HCP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26.01.2015 17:50, Andrei Borzenkov wrote: > =D0=92 Mon, 26 Jan 2015 18:12:19 +0300 > Andrei Borzenkov =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 >> On Mon, Jan 26, 2015 at 6:04 PM, Vladimir '=CF=86-coder/phcoder' Serbi= nenko >> wrote: >>> On 26.01.2015 12:29, Andrei Borzenkov wrote: >>>>> +CPPFLAGS=3D"$CPPFLAGS -D_FILE_OFFSET_BITS=3D64" >>>>> +HOST_CPPFLAGS=3D"$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=3D64" >>>> >>>> >>>> We already have them unconditionally in config.h. This is confusing;= >>>> may be remove them from this file. OTOH we have AC_LARGEFILES that i= s >>>> expected to figure out proper options (although I believe for now >>>> there is just one system that needs it). >>>> >>> Do you mean AC_SYS_LARGEFILE ? Does it actually work? >> >> It apparently works for other projects ... >> >>> = How exactly does >>> it make its way to HOST_CPPFLAGS? >> >> It does not, that is my point. >=20 > Sorry, was wrong. It makes it way via config-util.h >=20 > AC_CONFIG_HEADER([config-util.h]) >=20 > and=20 >=20 > /* Number of bits in a file offset, on hosts where this is settable. */= > /* #undef _FILE_OFFSET_BITS */ >=20 > /* Define for large files, on AIX-style hosts. */ > /* #undef _LARGE_FILES */ >=20 > I'm on 64 bit Linux so do not need any of these to enable large files. > So your patch seems to be redundant and I'd consider removing them from= > config.h as well after release. >=20 fuse headers need explicit _FILE_OFFSET_BITS and so we need to include them for fuse tests. Also we need to include them for 64-bit off_t availability tests. --nhB1cmLJxAh8xefLLrt4T7Mp2cRxj8HCP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlTHvLsACgkQmBXlbbo5nOt+aAEAmojN76N05fpCyA8vYMzB/gLw 9iPdcmo3wEt2uyyFekoA+QGql7HVAe9HYQr2BEhA6vMe8MCdAkjxEoTQG3y5W1Gx =KWjE -----END PGP SIGNATURE----- --nhB1cmLJxAh8xefLLrt4T7Mp2cRxj8HCP--