All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Daniel Martin <daniel.martin@secunet.com>,
	linux-input@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [v2] synaptics: match PNP-Id is not sufficient for min/max quirks
Date: Tue, 27 Jan 2015 17:36:00 +0100	[thread overview]
Message-ID: <54C7BE70.7000802@redhat.com> (raw)
In-Reply-To: <1422347645-5194-1-git-send-email-daniel.martin@secunet.com>

Hi,

On 01/27/2015 09:34 AM, Daniel Martin wrote:
> Hi,
>
> this is the second version of my patches to address the problems
> described at:
>      https://bugzilla.kernel.org/show_bug.cgi?id=91541
>
> I have incorporated changes according to Hans comments. That means I
> removed the patch
>      Input: synaptics - Add PnP id for X1 Carbon 1nd
> as the PnP id doesn't belong into the list topbuttonpad_pnp_ids and in
> the first patch
>      Input: synaptics - Split synaptics_resolution(), query ...
> I removed the SYN_ID_MAJOR() major check.

Patch set looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

> Is there anything else I should change?

That is up to Dmitry, btw when sending input patches you should send
them directly to Dmitry with the list in the Cc, I've added Dmitry to
the Cc now.

Regards,

Hans

      parent reply	other threads:[~2015-01-27 16:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 16:46 synaptics: match PNP-Id is not sufficient for min/max quirks Daniel Martin
2015-01-22 16:46 ` [PATCH 1/6] Input: synaptics - Split synaptics_resolution(), query first Daniel Martin
2015-01-22 16:46 ` [PATCH 2/6] Input: synaptics - Log queried and quirked dimension values Daniel Martin
2015-01-22 16:46 ` [PATCH 3/6] Input: synaptics - Query min dimensions when safe firmware Daniel Martin
2015-01-22 16:46 ` [PATCH 4/6] Input: synaptics - Skip quirks when post-2013 dimensions Daniel Martin
2015-01-22 16:46 ` [PATCH 5/6] Input: synaptics - Add PnP id for X1 Carbon 1nd Daniel Martin
2015-01-23  8:42   ` Daniel Martin
2015-01-23 13:40   ` Daniel Martin
2015-01-22 16:46 ` [PATCH 6/6] Input: synaptics - Remove obsolete min/max quirk for X240 Daniel Martin
2015-01-27  8:34 ` [v2] synaptics: match PNP-Id is not sufficient for min/max quirks Daniel Martin
2015-01-27  8:34   ` [PATCH v2 1/5] Input: synaptics - Split synaptics_resolution(), query first Daniel Martin
2015-01-27  8:34   ` [PATCH v2 2/5] Input: synaptics - Log queried and quirked dimension values Daniel Martin
2015-01-27  8:34   ` [PATCH v2 3/5] Input: synaptics - Query min dimensions when safe firmware Daniel Martin
2015-01-29 18:48     ` Benjamin Tissoires
2015-01-30  9:03       ` Hans de Goede
2015-01-30 15:41         ` Benjamin Tissoires
2015-01-30 22:35           ` Andrew Duggan
2015-01-31  8:11             ` Daniel Martin
2015-01-27  8:34   ` [PATCH v2 4/5] Input: synaptics - Skip quirks when post-2013 dimensions Daniel Martin
2015-01-29 19:02     ` Benjamin Tissoires
2015-01-29 19:50       ` Benjamin Tissoires
2015-01-30  9:59         ` Hans de Goede
2015-01-30 15:34           ` Benjamin Tissoires
2015-01-30 22:47             ` Andrew Duggan
2015-01-31  8:18             ` Daniel Martin
2015-02-05 21:22               ` Benjamin Tissoires
2015-02-07  8:02                 ` Hans de Goede
2015-01-27  8:34   ` [PATCH v2 5/5] Input: synaptics - Remove obsolete min/max quirk for X240 Daniel Martin
2015-01-27 16:36   ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C7BE70.7000802@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=daniel.martin@secunet.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.