From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 10/12] xen/iommu: smmu: Check for duplicate stream IDs when registering master devices Date: Tue, 27 Jan 2015 16:52:51 +0000 Message-ID: <54C7C263.7090806@linaro.org> References: <1421418247-30068-1-git-send-email-julien.grall@linaro.org> <1421418247-30068-11-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YG9OC-0003M3-Sh for xen-devel@lists.xenproject.org; Tue, 27 Jan 2015 16:53:21 +0000 Received: by mail-we0-f169.google.com with SMTP id u56so16061725wes.0 for ; Tue, 27 Jan 2015 08:53:19 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: ian.campbell@citrix.com, tim@xen.org, Andreas Herrmann , stefano.stabellini@citrix.com, Andreas Herrmann , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 27/01/15 16:30, Stefano Stabellini wrote: > On Fri, 16 Jan 2015, Julien Grall wrote: >> From: Andreas Herrmann >> >> If DT information lists one stream ID twice for the master devices of >> an SMMU this can cause a multi match when stream ID matching is used. >> For stream ID indexing this might trigger an overwrite of an S2CR that >> is already in use. >> >> So better check for duplicates when DT information is parsed. >> >> Taken from the linux ML: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/226099.html >> >> Cc: Andreas Herrmann >> Signed-off-by: Andreas Herrmann >> Signed-off-by: Julien Grall > > Why didn't you just take a more recent version of the Linux smmu driver? The SMMU driver very is recent (see commit in the previous patch)... Just this patch has never reached upstream. Regards, -- Julien Grall