Re: [PATCH] can/peak_usb: mark current PEAK USB FD as non-ISO

[Oliver Hartkopp <socketcan@hartkopp.net>]

Hello Marc,

your v10 series looks very good. The ARRAY_SIZE stuff is a good improvement!

I compiled the peak-next branch and inserting my single PCAN USB FD adapter 
worked fine. I'll send my tested-by when I can access my second adapter at 
work tomorrow.

The  patch below finally sets the CAN_CTRLMODE_FD_NON_ISO flag.
It's tested with the updated ip tool.

But beware: The current linux-can-next is missing the CAN_CTRLMODE_FD_NON_ISO 
patch for M_CAN. Therefore CAN_CTRLMODE_FD_NON_ISO is not defined until Dave 
pulled net into net-next. So this patch creates a compile error in the latest 
linux-can-next.

Regards,
Oliver

On 27.01.2015 18:58, Oliver Hartkopp wrote:
> The current PCAN USB FD (pro) adapters support the non-ISO CAN FD protocol.
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> ---
>   drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> index e4d9354..962c3f0 100644
> --- a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> +++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> @@ -860,6 +860,9 @@ static int pcan_usb_fd_init(struct peak_usb_device *dev)
>   			 pdev->usb_if->fw_info.fw_version[2],
>   			 dev->adapter->ctrl_count);
>
> +		/* the currently supported hw is non-ISO */
> +		dev->can.ctrlmode = CAN_CTRLMODE_FD_NON_ISO;
> +
>   		/* tell the hardware the can driver is running */
>   		err = pcan_usb_fd_drv_loaded(dev, 1);
>   		if (err) {
>