From: Eric Blake <eblake@redhat.com>
To: Peter Krempa <pkrempa@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] pc: memory: Validate alignment of maxram_size to page size
Date: Tue, 27 Jan 2015 11:16:26 -0700 [thread overview]
Message-ID: <54C7D5FA.8050509@redhat.com> (raw)
In-Reply-To: <51cf53611ea22a2c1ca0d55ad5e8ab13dcdea26f.1422285793.git.pkrempa@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On 01/26/2015 08:31 AM, Peter Krempa wrote:
> If the maxram_size is not aligned and dimm devices were added on the
> command line qemu would terminate with a rather unhelpful message:
>
> ERROR:hw/mem/pc-dimm.c:150:pc_dimm_get_free_addr: assertion failed:
> (QEMU_ALIGN_UP(address_space_size, align) == address_space_size)
>
> In case no dimm device was originally added on the commandline qemu
> exits on the assertion failure.
>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
> hw/i386/pc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-01-27 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 15:31 [Qemu-devel] [PATCH 0/2] pc: Fix startup with memory hotplug enabled Peter Krempa
2015-01-26 15:31 ` [Qemu-devel] [PATCH 1/2] vl.c: Fix error messages when parsing maxmem parameters Peter Krempa
2015-01-27 18:15 ` Eric Blake
2015-01-28 7:18 ` Peter Krempa
2015-01-26 15:31 ` [Qemu-devel] [PATCH 2/2] pc: memory: Validate alignment of maxram_size to page size Peter Krempa
2015-01-27 18:16 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C7D5FA.8050509@redhat.com \
--to=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.