From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests][PATCH] x86: hypercall: fix compile error on i386 Date: Tue, 27 Jan 2015 21:27:50 +0100 Message-ID: <54C7F4C6.5000407@redhat.com> References: <1422390185-27896-1-git-send-email-chris.j.arges@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE To: Chris J Arges , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38387 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759674AbbA0U14 (ORCPT ); Tue, 27 Jan 2015 15:27:56 -0500 In-Reply-To: <1422390185-27896-1-git-send-email-chris.j.arges@canonical.com> Sender: kvm-owner@vger.kernel.org List-ID: On 27/01/2015 21:23, Chris J Arges wrote: > There is a failure to build on 32-bit hosts: > x86/hypercall.c: In function =E2=80=98test_edge=E2=80=99: > x86/hypercall.c:42:2: error: =E2=80=98test_rip=E2=80=99 undeclared (f= irst use in this function) > test_rip =3D 0; > ^ >=20 > This patch fixes this issue. >=20 > Signed-off-by: Chris J Arges > --- > x86/hypercall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/x86/hypercall.c b/x86/hypercall.c > index 1548421..3ac5ff9 100644 > --- a/x86/hypercall.c > +++ b/x86/hypercall.c > @@ -24,8 +24,8 @@ static inline long kvm_hypercall0_amd(unsigned int = nr) > } > =20 > =20 > -#ifdef __x86_64__ > volatile unsigned long test_rip; > +#ifdef __x86_64__ > extern void gp_tss(void); > asm ("gp_tss: \n\t" > "add $8, %rsp\n\t" // discard error code >=20 Thanks, applied. Paolo