From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm: update_memslots: clean flags for invalid memslots Date: Tue, 27 Jan 2015 21:31:55 +0100 Message-ID: <54C7F5BB.4080204@redhat.com> References: <1420792154-32454-1-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Tiejun Chen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55600 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759655AbbA0UcA (ORCPT ); Tue, 27 Jan 2015 15:32:00 -0500 In-Reply-To: <1420792154-32454-1-git-send-email-tiejun.chen@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/01/2015 09:29, Tiejun Chen wrote: > Indeed, any invalid memslots should be new->npages = 0, > new->base_gfn = 0 and new->flags = 0 at the same time. > > Signed-off-by: Tiejun Chen > --- > Paolo, > > This is just a small cleanup to follow-up commit, efbeec7098ee, "fix > sorting of memslots with base_gfn == 0". > > Tiejun > > virt/kvm/kvm_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 1cc6e2e..369c759 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -673,6 +673,7 @@ static void update_memslots(struct kvm_memslots *slots, > if (!new->npages) { > WARN_ON(!mslots[i].npages); > new->base_gfn = 0; > + new->flags = 0; > if (mslots[i].npages) > slots->used_slots--; > } else { > Applied to kvm/queue. Paolo