All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains
Date: Tue, 27 Jan 2015 22:13:08 +0100	[thread overview]
Message-ID: <54C7FF64.3030501@mind.be> (raw)
In-Reply-To: <1422225691-15930-1-git-send-email-yann.morin.1998@free.fr>

On 25/01/15 23:41, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  toolchain/helpers.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index 3121da4..61a3639 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -347,6 +347,11 @@ check_unusable_toolchain = \
>  		echo "them unsuitable as external toolchains for build systems" ; \
>  		echo "such as Buildroot." ; \
>  		exit 1 ; \
> +	fi; \
> +	with_sysroot=`$${__CROSS_CC} -v 2>&1 |sed -r -e '/.* --with-sysroot=([^[:space:]]+)[[:space:]].*/!d; s//\1/'`; \
> +	if test "$${with_sysroot}"  = "/" ; then \
> +		echo "Distribution toolchains are unsuitable for use by Buildroot," ; \
> +		echo "as they were configured in a way that makes them non-relocatable."; \

 This sounds as if the problem is that the binary can't be moved to a different
place. But for pre-installed external toolchains, we don't do that.

 But I guess the real problem is that we can't copy the libs to the staging dir,
right? So perhaps that should be written in this remark.

 Regards,
 Arnout

>  	fi
>  
>  #
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2015-01-27 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 22:41 [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains Yann E. MORIN
2015-01-27 21:13 ` Arnout Vandecappelle [this message]
2015-01-27 21:16   ` Thomas Petazzoni
2015-01-28 18:34     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C7FF64.3030501@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.