From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] misc/xenmicrocode: Upload
 /lib/firmware/<some blob> to the hypervisor
Date: Tue, 27 Jan 2015 16:25:09 -0500
Message-ID: <54C80235.2020302@oracle.com>
References: <1422389461-19333-1-git-send-email-mcgrof@do-not-panic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <boris.ostrovsky@oracle.com>) id 1YGDds-0003nA-7g
	for xen-devel@lists.xenproject.org; Tue, 27 Jan 2015 21:25:48 +0000
In-Reply-To: <1422389461-19333-1-git-send-email-mcgrof@do-not-panic.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>, stefano.stabellini@eu.citrix.com
Cc: Juergen Gross <jgross@suse.com>, Michal Marek <mmarek@suse.cz>, Jason Douglas <jdouglas@suse.com>, Takashi Iwai <tiwai@suse.de>, mcgrof@suse.com, Henrique de Moraes Holschuh <hmh@debian.org>, david.vrabel@citrix.com, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xenproject.org, Borislav Petkov <bp@suse.de>, Olaf Hering <ohering@suse.de>
List-Id: xen-devel@lists.xenproject.org

On 01/27/2015 03:11 PM, Luis R. Rodriguez wrote:
> +    fbuf = mmap(0, len, PROT_READ, MAP_PRIVATE, fd, 0);
> +
> +    if ((xc_handle = xc_interface_open(0,0,0)) == 0)
> +    {
> +        fprintf(stderr, "Error opening xc interface: %d (%s)\n",
> +                errno, strerror(errno));
> +        return 1;
> +    }
> +
> +    if (fbuf == MAP_FAILED)
> +    {
> +        printf("Could not map: error: %d(%s)\n", errno,
> +               strerror(errno));
> +        return errno;
> +    }

Shouldn't this 'if' block directly follow the mmap()?

> +
> +    uc = xc_hypercall_buffer_alloc(xc_handle, uc, len);
> +    memcpy(uc, fbuf, len);
> +
> +    set_xen_guest_handle(op.u.microcode.data, uc);
> +    op.cmd = XENPF_microcode_update;
> +    op.interface_version = XENPF_INTERFACE_VERSION;
> +    op.u.microcode.length = len;
> +    xc_platform_op(xc_handle, &op);
> +
> +    xc_hypercall_buffer_free(xc_handle, uc);
> +    xc_interface_close(xc_handle);
> +
> +    if (munmap(fbuf, len))
> +    {
> +        printf("Could not unmap: %d(%s)\n", errno, strerror(errno));
> +        return errno;
> +    }
> +
> +    close(fd);

Given that you never close the file on errors this is not really 
necessary. Or you should close it on errors for consistency.


-boris