From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 0/6] KVM: nVMX: Enable nested apicv support.
Date: Tue, 27 Jan 2015 23:06:12 +0100
Message-ID: <54C80BD4.5080800@redhat.com>
References: <CACzj_yVKMMJMdNjCn=64sqgEtcG9Jn3j=JitsprWB=hNnf19Ng@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Wanpeng Li <wanpeng.li@linux.intel.com>,
	Jan Kiszka <jan.kiszka@web.de>
To: Wincy Van <fanwenyi0529@gmail.com>,
	"gleb@kernel.org" <gleb@kernel.org>,
	"Zhang, Yang Z" <yang.z.zhang@intel.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CACzj_yVKMMJMdNjCn=64sqgEtcG9Jn3j=JitsprWB=hNnf19Ng@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 24/01/2015 11:18, Wincy Van wrote:
> v2 ---> v3:
>   1. Add a new field in nested_vmx to avoid the spin lock in v2.
>   2. Drop send eoi to L1 when doing nested interrupt delivery.
>   3. Use hardware MSR bitmap to enable nested virtualize x2apic
>      mode.

I think the patches are mostly okay.  I made a few comments.

One of the things to do on top could be to avoid rebuilding the whole
vmcs02 on every entry.  Recomputing the MSR bitmap on every vmentry is
not particularly nice, for example.  It is not necessary unless the
execution controls have changed.

Paolo