From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 04/12] xen/arm: device: Rename
	device_type into device_match
Date: Tue, 27 Jan 2015 22:26:39 +0000
Message-ID: <54C8109F.80600@linaro.org>
References: <1421418247-30068-1-git-send-email-julien.grall@linaro.org>
	<1421418247-30068-5-git-send-email-julien.grall@linaro.org>
	<alpine.DEB.2.02.1501271602260.9702@kaball.uk.xensource.com>
	<54C7B837.9000408@linaro.org>
	<alpine.DEB.2.02.1501271613300.9702@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YGEaq-0007uD-FI
	for xen-devel@lists.xenproject.org; Tue, 27 Jan 2015 22:26:44 +0000
Received: by mail-we0-f175.google.com with SMTP id p10so17559100wes.6
	for <xen-devel@lists.xenproject.org>;
	Tue, 27 Jan 2015 14:26:42 -0800 (PST)
In-Reply-To: <alpine.DEB.2.02.1501271613300.9702@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org



On 27/01/2015 16:13, Stefano Stabellini wrote:
> On Tue, 27 Jan 2015, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 27/01/15 16:05, Stefano Stabellini wrote:
>>> On Fri, 16 Jan 2015, Julien Grall wrote:
>>>> This enum was used for matching a specific device and not to get the
>>>> type of device.
>>>>
>>>> Hence the name device_type will be used for another purpose later.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>>
>>> If you really want to rename this field, please find a more descriptive
>>> name for it. device_match doesn't really tell me what we are trying to
>>> match against.  At least device_type would tell me that we are matching
>>> against the type.
>>
>> I was struggling to find a correct name. For me device_type refers to
>> PCI/platform device. And it will be used this way later.
>>
>> Maybe device_category?
>
> Yes, or device_class

device_class seems better. I will use it in the next version.

Regards,


-- 
Julien Grall