All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Andy Gospodarek <gospo@cumulusnetworks.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	netdev@vger.kernel.org
Subject: Re: [RFC PATCH] net: ipv6: Make address flushing on ifdown optional
Date: Tue, 27 Jan 2015 20:21:58 -0700	[thread overview]
Message-ID: <54C855D6.7050500@gmail.com> (raw)
In-Reply-To: <1422372523.13969.23.camel@stressinduktion.org>


On 01/27/2015 08:28 AM, Hannes Frederic Sowa wrote:
>>   From the discussion a second patch is needed to make sure DAD is done
>> on a link up if there is an address configured.
>
> Thank you!
>
> Let's see if the DAD patch isn't complex, maybe it is a candidate for
> stable?

Actually, DAD is done on a link up; you can see the notifications go out 
when the link is brought up:

18:46:28.519907 IP6 :: > ff02::1:ff00:10: ICMP6, neighbor solicitation, 
who has 2001:1::10, length 24
18:46:28.607650 IP6 :: > ff02::1:ff03:402: ICMP6, neighbor solicitation, 
who has fe80::1:2ff:fe03:402, length 24

So current top of tree works fine wrt DAD on addresses added when a link 
is down and then the link is brought up.

But, my previous patch does not re-send notifications on the up in a 
down-up cycle. I believe it is because the IFA_F_TENTATIVE flag is not 
set for the global address configured. I will address that in the 
revised patch.

David

  reply	other threads:[~2015-01-28  3:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 19:17 [RFC PATCH] net: ipv6: Make address flushing on ifdown optional David Ahern
2015-01-19 15:02 ` Hannes Frederic Sowa
2015-01-19 16:12   ` Harout Hedeshian
2015-01-19 19:11     ` Hannes Frederic Sowa
2015-01-20 17:07   ` David Ahern
2015-01-23  6:40 ` Stephen Hemminger
2015-01-23 12:22   ` Hannes Frederic Sowa
2015-01-27  4:56     ` Andy Gospodarek
2015-01-27  9:44       ` Hannes Frederic Sowa
2015-01-27 14:55         ` David Ahern
2015-01-27 15:28           ` Hannes Frederic Sowa
2015-01-28  3:21             ` David Ahern [this message]
2015-01-28  8:25               ` Hannes Frederic Sowa
2015-01-27 16:09         ` Andy Gospodarek
2015-01-23 18:47   ` David Ahern
2015-01-23 16:09 ` Brian Haley
2015-01-23 18:23   ` David Ahern
2015-01-23 21:17     ` Brian Haley
2015-01-26 16:49       ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C855D6.7050500@gmail.com \
    --to=dsahern@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.