From: Robert Baldyga <r.baldyga@samsung.com>
To: balbi@ti.com
Cc: paulz@synopsys.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()
Date: Wed, 28 Jan 2015 08:18:30 +0100 [thread overview]
Message-ID: <54C88D46.5080803@samsung.com> (raw)
In-Reply-To: <20150127154232.GE14623@saruman.tx.rr.com>
On 01/27/2015 04:42 PM, Felipe Balbi wrote:
> On Mon, Jan 05, 2015 at 10:31:35AM +0100, Robert Baldyga wrote:
>> This patch fixes in simpler way the bug described in [1] and [2]. It
>> looks like DWC2 is the only UDC driver that doesn't force usb requests
>> to complete in ep_disable() function. This causes described problem,
>> because we have no guarantee that all requests will be completed before
>> unbind of usb function.
>>
>> To fix this problem we force all requests of disabled endpoint to complete.
>> Also currently running request is not handled. This allowed to simplify
>> code of kill_all_requests() function, because 'force' parameter is always
>> set to true, so we don't need it anymore.
>>
>> In s3c_hsotg_rx_data() we change function used to print message when active
>> request is NULL from dev_warn() to dev_dbg(), because such situation is
>> harmless for driver and now it can take place during normal endpoint
>> disabling.
>>
>> [1] https://lkml.org/lkml/2014/12/9/283
>> [2] https://lkml.org/lkml/2014/12/12/360
>>
>> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
>
> this fails to apply:
>
> checking file drivers/usb/dwc2/gadget.c
> Hunk #1 succeeded at 2602 (offset 35 lines).
> Hunk #2 FAILED at 2588.
> Hunk #3 succeeded at 2645 (offset 36 lines).
> Hunk #4 FAILED at 2924.
> 2 out of 4 hunks FAILED
>
Isn't this patch already in linux-next? I see it's also in your 'next'
branch.
next prev parent reply other threads:[~2015-01-29 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 9:31 [PATCH 0/2] usb: dwc2: fix the uncompleted requests problem Robert Baldyga
2015-01-05 9:31 ` [PATCH 1/2] Revert "usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()" Robert Baldyga
2015-01-05 9:31 ` [PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests() Robert Baldyga
2015-01-27 15:42 ` Felipe Balbi
2015-01-28 7:18 ` Robert Baldyga [this message]
2015-01-28 14:08 ` Felipe Balbi
2015-01-20 6:12 ` [PATCH 0/2] usb: dwc2: fix the uncompleted requests problem Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C88D46.5080803@samsung.com \
--to=r.baldyga@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paulz@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.