Re: [PATCH] can: dev: fix crtlmode_supported check

[Oliver Hartkopp <socketcan@hartkopp.net>]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

Oh yes.

I got the entire thread twice.
I was assuming this to be the groundhog day :-)

See picture.

Regards,
Oliver

On 28.01.2015 09:25, Marc Kleine-Budde wrote:
> On 01/27/2015 08:12 PM, Oliver Hartkopp wrote:
>> When changing flags in the CAN drivers ctrlmode the provided new content has to
>> be checked whether the bits are allowed to be changed. The bits that are to be
>> changed are given as a bitfield in cm->mask. Therefore checking against
>> cm->flags is wrong as the content can hold any kind of values.
>>
>> The iproute2 tool sets the bits in cm->mask and cm->flags depending on the
>> detected command line options. To be robust against bogus user space
>> applications additionally sanitize the provided flags with the provided mask.
>>
>> (Backport of upstream commit 9b1087aa5e86448fe6ad40a58964e35f3ba423d5 for
>> Linux 3.2 .. Linux 3.14)
>
> Zefan Li <lizefan@huawei.com> is taking care of v3.4
>
> Marc
>

[-- Attachment #2: Bildschirmfoto - 28.01.2015 - 16:25:33.png --]
[-- Type: image/png, Size: 37967 bytes --]