From: Jens Axboe <axboe@kernel.dk>
To: Vasily Tarasov <tarasov@vasily.name>, fio@vger.kernel.org
Subject: Re: [PATCH] dedupe_percentage should work even if compress_percentage is not set
Date: Wed, 28 Jan 2015 09:11:51 -0700 [thread overview]
Message-ID: <54C90A47.8050901@kernel.dk> (raw)
In-Reply-To: <20150127192448.GA16313@vass-desktop>
On 01/27/2015 12:24 PM, Vasily Tarasov wrote:
> [PATCH] dedupe_percentage should work even if compress_percentage is not set
>
> Currently dedupe_percentage option does not work properly if compress_percentage
> is not set. This can be easily demonstrated using the following job file:
>
> [job-/dev/dm-0]
> filename=/dev/dm-0
> rw=randwrite
> blocksize=4096
> direct=1
> ioengine=libaio
> iodepth=32
> dedupe_percentage=50
> time_based=1
> runtime=5
> numjobs=1
>
> All writes will contain zeroes for the above job file.
>
> The problem is in fill_io_buffer() function that switches dedupe random state
> only if o->compress_percentage is set.
>
> This patch updates the condition appropriately in fill_io_buffer()
> appropriately.
Thanks, looks good, applied.
--
Jens Axboe
prev parent reply other threads:[~2015-01-28 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 19:24 [PATCH] dedupe_percentage should work even if compress_percentage is not set Vasily Tarasov
2015-01-28 16:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C90A47.8050901@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=tarasov@vasily.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.