From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 06/24] xen/arm: Map disabled device in DOM0 Date: Wed, 28 Jan 2015 16:23:09 +0000 Message-ID: <54C90CED.20909@linaro.org> References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org> <1421159133-31526-7-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YGVP2-0008WE-F1 for xen-devel@lists.xenproject.org; Wed, 28 Jan 2015 16:23:40 +0000 Received: by mail-wi0-f172.google.com with SMTP id h11so13124410wiw.5 for ; Wed, 28 Jan 2015 08:23:39 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com, Andrii Tseglytskyi List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 28/01/15 16:18, Stefano Stabellini wrote: > On Tue, 13 Jan 2015, Julien Grall wrote: >> The check to avoid mapping disabled device in DOM0 was added in the anticipation >> of the device passthrough. But, a brand new property will be added later to mark >> device which will passthrough. At the same time, remove the memory type >> check because those nodes has been blacklisted. > > Sorry, I don't understand the explanation on why you removed the check > on dt_device_type_is_equal(node, "memory") too. The memory nodes has been skipped earlier via the skip_matches variable. How about "Also, remove the memory type check as we already skipped them earlier in the function"? Regards, -- Julien Grall