From: James Hartley <james.hartley@imgtec.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andrew Bresticker <abrestic@chromium.org>,
Ezequiel Garcia <Ezequiel.Garcia@imgtec.com>,
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] crypto: Add Imagination Technologies hw hash accelerator
Date: Wed, 28 Jan 2015 19:19:09 +0000 [thread overview]
Message-ID: <54C9362D.1050409@imgtec.com> (raw)
In-Reply-To: <20150128005640.GA12143@gondor.apana.org.au>
On 01/28/15 00:56, Herbert Xu wrote:
> On Wed, Jan 28, 2015 at 12:29:29AM +0000, James Hartley wrote:
>> - If it is mandatory to impement a fallback driver (because the
>> potential users of the framework would not know only digest is
>> supported?)
> Yes it is mandatory.
>
>> If I need to implement fallback drivers, would the Niagra2 SPU
>> driver be a good reference
>> http://lxr.free-electrons.com/source/drivers/crypto/n2_core.c ?
> Yes it's a good example.
>
> Cheers,
Great, I'll prepare a new patchset. For the previous patches I did some
basic testing using the built in crypto manager tests, but these all
pass without the fallback implemented - is there another more
appropriate set of tests that you would recommend I use to verify that
my implementation is correct?
Thanks,
James
next prev parent reply other threads:[~2015-01-29 3:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54C826EC.8050103@imgtec.com>
2015-01-28 0:29 ` [PATCH V2 1/2] crypto: Add Imagination Technologies hw hash accelerator James Hartley
2015-01-28 0:56 ` Herbert Xu
2015-01-28 19:19 ` James Hartley [this message]
2014-11-18 20:48 [PATCH V2 0/2] crypto: Add support for the IMG " James Hartley
2014-11-18 20:48 ` [PATCH V2 1/2] crypto: Add Imagination Technologies hw " James Hartley
2014-11-18 20:48 ` James Hartley
2014-11-20 14:22 ` Herbert Xu
2014-11-24 17:22 ` James Hartley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C9362D.1050409@imgtec.com \
--to=james.hartley@imgtec.com \
--cc=Ezequiel.Garcia@imgtec.com \
--cc=abrestic@chromium.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.