From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGYj6-0002L5-2Y for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:56:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGYj1-0007Xj-5M for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:56:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGYj0-0007Xd-Sm for qemu-devel@nongnu.org; Wed, 28 Jan 2015 14:56:31 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SJuU5Z003885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 14:56:30 -0500 Message-ID: <54C93EEC.4010302@redhat.com> Date: Wed, 28 Jan 2015 12:56:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-39-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-39-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tL0HrJwPDxewPflidjCK2kWc9jBa2G05s" Subject: Re: [Qemu-devel] [PATCH RESEND 38/50] blockdev: Add blockdev-open-tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tL0HrJwPDxewPflidjCK2kWc9jBa2G05s Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:46 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++= ++++ > qapi/block-core.json | 21 +++++++++++++++++++++ > qmp-commands.hx | 37 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 106 insertions(+) >=20 > +Example (1): > + With only one example, the (1) doesn't add much. Minor whether you leave it in or take it out. > +-> { "execute": "blockdev-open-tray", > + "arguments": { "device": "ide1-cd0" } } > + > +<- { "timestamp": { "seconds": 1418751016, > + "microseconds": 716996 }, > + "event": "DEVICE_TRAY_MOVED", > + "data": { "device": "ide1-cd0", > + "tray-open": true } } > + > +<- { "return": {} } Nice inclusion of the event alongside the return code! Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tL0HrJwPDxewPflidjCK2kWc9jBa2G05s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyT7sAAoJEKeha0olJ0NqiQkIAJK91BTOmQxBi0jSVUhevq6R G4ex5ZFcfh0a2uEkgCWLnUof0+mTmpH5I17YK5898vrqlTbfbSlVugFkhXu85muk L5rY6aQMAyvK3SG02mONAMJsLxJUhvIuSaBzeYL7GvF8Vh7o5aS2cj2gGgMiz7oI B8uNGhVxuJ+5LWlFyFjaRL5fns2t+vPYoecvXymH7bwCJ71ACoTM5m5ZPdhD0EcA wQfhU2eKD89O9DroqSlMo0TzOGgm8TPzTV6iQE3u2qo87sbUbNPHCvEjfv2ygpyH KkTfZqAkMUhYjgQ0ojqrn3BBCY0gZIdTYEW3BQSoP3yNG+nj8+2RfeuxC6OoKqk= =WE12 -----END PGP SIGNATURE----- --tL0HrJwPDxewPflidjCK2kWc9jBa2G05s--