From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH] ioreq-server: handle IOREQ_TYPE_PCI_CONFIG
 in assist function
Date: Wed, 28 Jan 2015 15:03:19 -0500
Message-ID: <54C94087.8040808@terremark.com>
References: <1422385589-17316-1-git-send-email-wei.liu2@citrix.com>	<54C7E85E.2090100@citrix.com>
	<54C8B954020000780005A354@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <dslutz@verizon.com>) id 1YGYpg-0000ut-Dx
	for xen-devel@lists.xenproject.org; Wed, 28 Jan 2015 20:03:24 +0000
In-Reply-To: <54C8B954020000780005A354@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Paul Durrant <paul.durrant@citrix.com>
List-Id: xen-devel@lists.xenproject.org

...
> (Looking at the surrounding code I'm also puzzled by all the
> pci_write?()-s in that bus scanning loop: Most if not all of them
> should be done by the BIOS, not hvmloader. But of course that's
> the case for the BAR setup further down too.)
> 

I do not know the history, but seabios (which would
normally do this) has the statements (in qemu_platform_setup()):

    if (runningOnXen()) {
...
   return
}

    // Initialize pci


    pci_setup();

Which expects that hvmloader has done the pci_setup().

   -Don Slutz


> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>