All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/8] MIPS cache code cleanup
Date: Wed, 28 Jan 2015 21:31:25 +0100	[thread overview]
Message-ID: <54C9471D.1080505@gmail.com> (raw)
In-Reply-To: <1422284580-2608-1-git-send-email-paul.burton@imgtec.com>

Hi Paul,

Am 26.01.2015 um 16:02 schrieb Paul Burton:
> This series cleans up the MIPS cache code somewhat, and unifies the
> mips32 & mips64 implementations of it. This is largely in preparation
> for further patches adding L2 cache support. The final patch of this
> series fixes a bug encountered with recent cores on Malta boards.

thanks for doing this. I also have this on my to-do list.

Just a thought: if we finally have just the mips_cache_reset function in
cache_init.S, couldn't we reimplement it in C entirely? I see no reason
to implement it in assembler.

> 
> Paul Burton (8):
>   MIPS: avoid .set ISA for cache operations
>   MIPS: unify cache maintenance functions
>   MIPS: unify cache initialization code
>   MIPS: refactor L1 cache config reads to a macro
>   MIPS: refactor cache loops to a macro
>   MIPS: inline mips_init_[id]cache functions
>   MIPS: allow systems to skip loads during cache init
>   MIPS: clear TagLo select 2 during cache init
> 
>  arch/mips/Kconfig                                  |   6 +
>  arch/mips/cpu/mips32/Makefile                      |   3 +-
>  arch/mips/cpu/mips32/cpu.c                         | 119 -----------
>  arch/mips/cpu/mips64/Makefile                      |   2 +-
>  arch/mips/cpu/mips64/cache.S                       | 213 --------------------
>  arch/mips/cpu/mips64/cpu.c                         |  58 ------
>  arch/mips/include/asm/cacheops.h                   |   7 +
>  arch/mips/lib/Makefile                             |   2 +
>  arch/mips/lib/cache.c                              | 118 +++++++++++
>  arch/mips/{cpu/mips32/cache.S => lib/cache_init.S} | 222 +++++++++------------
>  10 files changed, 226 insertions(+), 524 deletions(-)
>  delete mode 100644 arch/mips/cpu/mips64/cache.S
>  create mode 100644 arch/mips/lib/cache.c
>  rename arch/mips/{cpu/mips32/cache.S => lib/cache_init.S} (59%)
> 

-- 
- Daniel

  parent reply	other threads:[~2015-01-28 20:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 15:02 [U-Boot] [PATCH 0/8] MIPS cache code cleanup Paul Burton
2015-01-26 15:02 ` [U-Boot] [PATCH 1/8] MIPS: avoid .set ISA for cache operations Paul Burton
2015-01-28 20:43   ` Daniel Schwierzeck
2015-01-28 21:08     ` Paul Burton
2015-01-28 21:18       ` Daniel Schwierzeck
2015-01-26 15:02 ` [U-Boot] [PATCH 2/8] MIPS: unify cache maintenance functions Paul Burton
2015-01-26 15:02 ` [U-Boot] [PATCH 3/8] MIPS: unify cache initialization code Paul Burton
2015-01-26 15:02 ` [U-Boot] [PATCH 4/8] MIPS: refactor L1 cache config reads to a macro Paul Burton
2015-01-26 15:02 ` [U-Boot] [PATCH 5/8] MIPS: refactor cache loops " Paul Burton
2015-01-26 15:02 ` [U-Boot] [PATCH 6/8] MIPS: inline mips_init_[id]cache functions Paul Burton
2015-01-26 15:02 ` [U-Boot] [PATCH 7/8] MIPS: allow systems to skip loads during cache init Paul Burton
2015-01-26 15:03 ` [U-Boot] [PATCH 8/8] MIPS: clear TagLo select 2 " Paul Burton
2015-01-28 20:57   ` Daniel Schwierzeck
2015-01-28 21:13     ` Paul Burton
2015-01-28 20:31 ` Daniel Schwierzeck [this message]
2015-01-28 21:05   ` [U-Boot] [PATCH 0/8] MIPS cache code cleanup Paul Burton
     [not found]     ` <54C95453.8010009@gmail.com>
2015-01-28 22:21       ` Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C9471D.1080505@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.