From: Xander Huff <xander.huff@ni.com>
To: mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org
Cc: linux-rt-users@vger.kernel.org, josh.cartwright@ni.com,
gratian.crisan@ni.com, linux-kernel@vger.kernel.org,
jaeden.amero@ni.com, ben.shelton@ni.com, brad.mouring@ni.com,
rich.tollerton@ni.com
Subject: Re: [PATCH -rt] lockdep: selftest: fix warnings due to missing PREEMPT_RT conditionals
Date: Wed, 28 Jan 2015 15:06:59 -0600 [thread overview]
Message-ID: <54C94F73.3010006@ni.com> (raw)
In-Reply-To: <1422472125-21979-1-git-send-email-xander.huff@ni.com>
On 1/28/2015 1:08 PM, Xander Huff wrote:
> From: Josh Cartwright <josh.cartwright@ni.com>
>
> "lockdep: Selftest: Only do hardirq context test for raw spinlock"
> disabled the execution of certain tests with PREEMPT_RT_FULL, but did
> not prevent the tests from still being defined. This leads to warnings
> like:
>
> ./linux/lib/locking-selftest.c:574:1: warning: 'irqsafe1_hard_rlock_12' defined but not used [-Wunused-function]
> ./linux/lib/locking-selftest.c:574:1: warning: 'irqsafe1_hard_rlock_21' defined but not used [-Wunused-function]
> ./linux/lib/locking-selftest.c:577:1: warning: 'irqsafe1_hard_wlock_12' defined but not used [-Wunused-function]
> ./linux/lib/locking-selftest.c:577:1: warning: 'irqsafe1_hard_wlock_21' defined but not used [-Wunused-function]
> ./linux/lib/locking-selftest.c:580:1: warning: 'irqsafe1_soft_spin_12' defined but not used [-Wunused-function]
> ...
>
> Fixed by wrapping the test definitions in #ifndef CONFIG_PREEMPT_RT_FULL
> conditionals.
>
> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
> Signed-off-by: Xander Huff <xander.huff@ni.com>
> Acked-by: Gratian Crisan <gratian.crisan@ni.com>
FYI: To be clearer, this should apply to all stable RT releases 3.4 and later.
--
Xander Huff
Staff Software Engineer
National Instruments
next prev parent reply other threads:[~2015-01-28 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 19:08 [PATCH -rt] lockdep: selftest: fix warnings due to missing PREEMPT_RT conditionals Xander Huff
2015-01-28 21:06 ` Xander Huff [this message]
2015-02-26 14:14 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C94F73.3010006@ni.com \
--to=xander.huff@ni.com \
--cc=ben.shelton@ni.com \
--cc=brad.mouring@ni.com \
--cc=gratian.crisan@ni.com \
--cc=jaeden.amero@ni.com \
--cc=josh.cartwright@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rich.tollerton@ni.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.