From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGacY-0004Db-Jy for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:57:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGacT-0002Z3-M4 for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:57:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGacT-0002Ym-Er for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:57:53 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SLvp7I030390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 16:57:52 -0500 Message-ID: <54C95B5E.9090604@redhat.com> Date: Wed, 28 Jan 2015 14:57:50 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-51-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-51-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="efTCAkUOig5TXtDqf7ODtjX90eOwHv1IQ" Subject: Re: [Qemu-devel] [PATCH RESEND 50/50] iotests: Add test for change-related QMP commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --efTCAkUOig5TXtDqf7ODtjX90eOwHv1IQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:46 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/118 | 649 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/118.out | 5 + > tests/qemu-iotests/group | 1 + > 3 files changed, 655 insertions(+) > create mode 100755 tests/qemu-iotests/118 > create mode 100644 tests/qemu-iotests/118.out >=20 Looks like lots of useful tests and good coverage, including things like no-op open of an already open tray. I didn't spot any obvious flaws (but my python is weak), or think of any obvious missing tests, so feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --efTCAkUOig5TXtDqf7ODtjX90eOwHv1IQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyVteAAoJEKeha0olJ0Nq8LsH/Rusi9LP4FIAp5reHaqUflrV ptav/Dpe0gA7EaDMVsP/m4/ugqnKRsg22QvLp2sJQNl029leRQflRJfjf9GlgRPy EtBHmyOJYRy62Oknbob967zDGUxtEnKzBNqoqyYJXz1LCSEOS1fEfqpHhkCcYqZd V90QkpMNEriZV6pubP2gCl0iCBRfHMAkBTXsGDls+uiEQ30KjnVPdKr/BMDdM5wb /ahJY/wJJ5XAzwJJuFgnFGtuQXchphdCsj+t2aaB2Ja+VAHWRUoIYdfbhqmK55Vg cG6aYCCoAqPO3+KeQnczpAl5xSOhvMjP0vL/0jBcq0J59GE5IA1ze9InM/U7aUY= =a5MH -----END PGP SIGNATURE----- --efTCAkUOig5TXtDqf7ODtjX90eOwHv1IQ--