From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YGcqh-0002gW-QW for mharc-qemu-trivial@gnu.org; Wed, 28 Jan 2015 19:20:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGcqf-0002eH-7J for qemu-trivial@nongnu.org; Wed, 28 Jan 2015 19:20:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGcqe-0004Aq-34 for qemu-trivial@nongnu.org; Wed, 28 Jan 2015 19:20:41 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:8787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGcqZ-00046J-0s; Wed, 28 Jan 2015 19:20:35 -0500 Received: from 172.24.2.119 (EHLO szxeml426-hub.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CGL83399; Thu, 29 Jan 2015 08:20:27 +0800 (CST) Received: from [127.0.0.1] (10.177.19.102) by szxeml426-hub.china.huawei.com (10.82.67.181) with Microsoft SMTP Server id 14.3.158.1; Thu, 29 Jan 2015 08:20:23 +0800 Message-ID: <54C97CB3.4050100@huawei.com> Date: Thu, 29 Jan 2015 08:20:03 +0800 From: Gonglei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Markus Armbruster References: <1422456844-13043-1-git-send-email-armbru@redhat.com> <1422456844-13043-2-git-send-email-armbru@redhat.com> In-Reply-To: <1422456844-13043-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.102] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.65 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/4] qemu-option: Replace pointless use of g_malloc0() by g_malloc() X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 00:20:42 -0000 On 2015/1/28 22:54, Markus Armbruster wrote: > get_opt_value() takes a write-only buffer, so zeroing it is pointless. > We don't do it elsewhere, either. > > Signed-off-by: Markus Armbruster > --- > util/qemu-option.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Gonglei From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGcqd-0002d5-41 for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:20:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGcqZ-00047k-PL for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:20:39 -0500 Message-ID: <54C97CB3.4050100@huawei.com> Date: Thu, 29 Jan 2015 08:20:03 +0800 From: Gonglei MIME-Version: 1.0 References: <1422456844-13043-1-git-send-email-armbru@redhat.com> <1422456844-13043-2-git-send-email-armbru@redhat.com> In-Reply-To: <1422456844-13043-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-option: Replace pointless use of g_malloc0() by g_malloc() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 2015/1/28 22:54, Markus Armbruster wrote: > get_opt_value() takes a write-only buffer, so zeroing it is pointless. > We don't do it elsewhere, either. > > Signed-off-by: Markus Armbruster > --- > util/qemu-option.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Gonglei