From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YGct5-0006KR-6Z for mharc-qemu-trivial@gnu.org; Wed, 28 Jan 2015 19:23:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGct2-0006F6-OV for qemu-trivial@nongnu.org; Wed, 28 Jan 2015 19:23:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGct1-0005Ae-Co for qemu-trivial@nongnu.org; Wed, 28 Jan 2015 19:23:08 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:18051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGcsv-00056Y-AB; Wed, 28 Jan 2015 19:23:01 -0500 Received: from 172.24.2.119 (EHLO szxeml434-hub.china.huawei.com) ([172.24.2.119]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id BBB84348; Thu, 29 Jan 2015 08:22:58 +0800 (CST) Received: from [127.0.0.1] (10.177.19.102) by szxeml434-hub.china.huawei.com (10.82.67.225) with Microsoft SMTP Server id 14.3.158.1; Thu, 29 Jan 2015 08:22:54 +0800 Message-ID: <54C97D5D.5070105@huawei.com> Date: Thu, 29 Jan 2015 08:22:53 +0800 From: Gonglei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Markus Armbruster References: <1422456844-13043-1-git-send-email-armbru@redhat.com> <1422456844-13043-5-git-send-email-armbru@redhat.com> In-Reply-To: <1422456844-13043-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.102] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.54C97D62.0199, ss=2, re=0.001, recu=0.000, reip=0.000, cl=2, cld=1, fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: de742bb17b58c4ad392fc7b4ca4a9200 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.66 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] usb: Pair g_malloc() with g_free(), not free() X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 00:23:10 -0000 On 2015/1/28 22:54, Markus Armbruster wrote: > Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled > and my "coverity: Model g_free() isn't necessarily free()" model patch > applied. > > Signed-off-by: Markus Armbruster > --- > hw/usb/desc-msos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/desc-msos.c b/hw/usb/desc-msos.c > index 334d1ae..32c3600 100644 > --- a/hw/usb/desc-msos.c > +++ b/hw/usb/desc-msos.c > @@ -231,7 +231,7 @@ int usb_desc_msos(const USBDesc *desc, USBPacket *p, > length = len; > } > memcpy(dest, buf, length); > - free(buf); > + g_free(buf); > > p->actual_length = length; > return 0; This patch had been added Gerd's usb queue :) http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01998.html Regards, -Gonglei From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGcsx-00065i-4E for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:23:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGcsv-00057t-TN for qemu-devel@nongnu.org; Wed, 28 Jan 2015 19:23:03 -0500 Message-ID: <54C97D5D.5070105@huawei.com> Date: Thu, 29 Jan 2015 08:22:53 +0800 From: Gonglei MIME-Version: 1.0 References: <1422456844-13043-1-git-send-email-armbru@redhat.com> <1422456844-13043-5-git-send-email-armbru@redhat.com> In-Reply-To: <1422456844-13043-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] usb: Pair g_malloc() with g_free(), not free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 2015/1/28 22:54, Markus Armbruster wrote: > Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled > and my "coverity: Model g_free() isn't necessarily free()" model patch > applied. > > Signed-off-by: Markus Armbruster > --- > hw/usb/desc-msos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/desc-msos.c b/hw/usb/desc-msos.c > index 334d1ae..32c3600 100644 > --- a/hw/usb/desc-msos.c > +++ b/hw/usb/desc-msos.c > @@ -231,7 +231,7 @@ int usb_desc_msos(const USBDesc *desc, USBPacket *p, > length = len; > } > memcpy(dest, buf, length); > - free(buf); > + g_free(buf); > > p->actual_length = length; > return 0; This patch had been added Gerd's usb queue :) http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01998.html Regards, -Gonglei