From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH for-4.5 v8 4/7] xen: Add vmware_port support Date: Wed, 28 Jan 2015 19:32:22 -0500 Message-ID: <54C97F96.9030503@terremark.com> References: <1412285417-19180-1-git-send-email-dslutz@verizon.com> <1412285417-19180-5-git-send-email-dslutz@verizon.com> <542DCA92.1030701@terremark.com> <542DD44F.6030101@terremark.com> <54B8F1740200007800055B42@mail.emea.novell.com> <54BFE768.3090309@terremark.com> <54C0C39F0200007800057F73@mail.emea.novell.com> <54C6643B.1@terremark.com> <54C67D8302000078000598E4@mail.emea.novell.com> <54C6A161.2010002@terremark.com> <54C7534E0200007800059B8E@mail.emea.novell.com> <54C8A985020000780005A302@mail.emea.novell.com> <54C96701.5040507@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54C96701.5040507@terremark.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz , Jan Beulich Cc: Jun Nakajima , Tim Deegan , Kevin Tian , Keir Fraser , Ian Campbell , Razvan Cojocaru , Stefano Stabellini , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org, Eddie Dong , Suravee Suthikulpanit , Tamas K Lengyel , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 01/28/15 17:47, Don Slutz wrote: > On 01/28/15 03:19, Jan Beulich wrote: >>>>> On 27.01.15 at 08:58, wrote: >>>>>> On 26.01.15 at 21:19, wrote: >>>> On 01/26/15 11:46, Jan Beulich wrote: > The delay is not in coding up this, but is that QEMU master (and now > xenbits's qemu staging) do not work with my changes and so far I am > unable to link why this is the case. I am adding a new hvm param > as part of getting vmport requests to QEMU (HVM_PARAM_VMPORT_REGS_PFN) > which changes QEMU to call xc_map_foreign_range() 1 more time. However > what is failing is hvmloader's pci setup and scan (~70 ioreqs work and > the next one hangs because it is sent to the default QEMU which does not > "exist" because of the patch in QEMU: > I have found the link. The following will reproduce my issue: 1) xl create -p 2) read one of HVM_PARAM_IOREQ_PFN, HVM_PARAM_BUFIOREQ_PFN, or HVM_PARAM_BUFIOREQ_EVTCHN 3) xl unpause new guest The guest will hang in hvmloader. More in thread: Subject: [Qemu-devel] [PATCH v5 2/2] Xen: Use the ioreq-server API when available Message-ID: <1417776605-36309-3-git-send-email-paul.durrant@citrix.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1417776605-36309-1-git-send-email-paul.durrant@citrix.com> -Don Slutz P.S. Can post info to xen-devel also if needed. > > commit 7665d6ba98e20fb05c420de947c1750fd47e5c07 > Author: Paul Durrant > Date: Tue Jan 20 11:06:19 2015 +0000 > > Xen: Use the ioreq-server API when available > > The ioreq-server API added to Xen 4.5 offers better security than > the existing Xen/QEMU interface because the shared pages that are > used to pass emulation request/results back and forth are removed > from the guest's memory space before any requests are serviced. > This prevents the guest from mapping these pages (they are in a > well known location) and attempting to attack QEMU by synthesizing > its own request structures. Hence, this patch modifies configure > to detect whether the API is available, and adds the necessary > code to use the API if it is. > > upstream-commit-id: 3996e85c1822e05c50250f8d2d1e57b6bea1229d > > Signed-off-by: Paul Durrant > Signed-off-by: Stefano Stabellini > Acked-by: Stefano Stabellini > > > > Since I had the code for handing off vmport requests to QEMU I was > planning on adding those patches to this patch set. Now that I have hit > a road block, the best I can do is put out a next RFC version of > these patches with the issue listed. > > So I will switch to spending most of my time on reworking (like a new > hvm_emulate_one_vmport() (or hvm_emulate_one_gp()). > > > -Don Slutz > >> Jan >>