All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] tzset.3: Add description for posixrules file
Date: Thu, 29 Jan 2015 06:51:35 +0100	[thread overview]
Message-ID: <54C9CA67.4080009@gmail.com> (raw)
In-Reply-To: <54C97B45.2070300-KK0ffGbhmjU@public.gmane.org>

Hi William,

This patch also does not apply. Some comments also below.

On 01/29/2015 01:13 AM, J William Piggott wrote:
> 
> Based upon reviewing the glibc source, the posixrules file is being used
> for very specific TZ strings that can be represented as:
> 
> [:]stdoffsetdst[offset][,]
> 
> If anything follows the above string, even invalid data, posixrules will
> not be used. Below is some shell output demonstrating this.
> 
> $ TZ="NZST-12:00:00NZDT-13:00:00,ANYTHING" \
>> strace -eopen date 2>&1 | grep -Ei 'posixrules|jan'
> Thu Jan 29 06:53:35 NZDT 2015
> 
> $ TZ="NZST-12:00:00NZDT-13:00:00," \
>> strace -eopen date 2>&1 | grep -Ei 'posixrules|jan'
> open("/usr/share/zoneinfo/posixrules", O_RDONLY|O_CLOEXEC) = 3
> Thu Jan 29 05:54:58 NZST 2015
> 
> Signed-off-by: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>
> ---
>  man3/tzset.3 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/man3/tzset.3 b/man3/tzset.3
> index 9011e5f..2e91fd8 100644
> --- a/man3/tzset.3
> +++ b/man3/tzset.3
> @@ -201,6 +201,11 @@ The system timezone file.
>  The system timezone database directory.
>  .TP
>  .B /usr/share/zoneinfo/posixrules
> +When a TZ string includes a dst timezone without anything following it,
> +then this file is used for the start/end rules. It is in the

Please start new sentences on new source lines. (See man-pages(7).)

> +.B tzfile(5)
> +format. By default, the zoneinfo Makefile hard links it to the

As above.

> +.IR America/New_York " tzfile."
>  .PP
>  Above are the current standard file locations, but they are
>  configurable when glibc is compiled.
> 

Thanks,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-01-29  5:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-18  0:30 [PATCH][COVER LETTER] tzset.3: correct file paths and TZ use JWP
     [not found] ` <54BAFE98.2090402-KK0ffGbhmjU@public.gmane.org>
2015-01-18  0:34   ` [PATCH] " JWP
     [not found]     ` <54BAFFAE.2020106-KK0ffGbhmjU@public.gmane.org>
2015-01-18 11:02       ` Michael Kerrisk (man-pages)
     [not found]         ` <54BB92AE.4090604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-23 17:29           ` JWP
     [not found]             ` <54C28516.7070802-KK0ffGbhmjU@public.gmane.org>
2015-01-25 13:43               ` Michael Kerrisk (man-pages)
2015-01-18 20:00   ` [PATCH[V2] 1/5] tzset.3: filespec omitted incorrect JWP
     [not found]     ` <54BC10C7.1030706-KK0ffGbhmjU@public.gmane.org>
2015-01-25 14:11       ` Michael Kerrisk (man-pages)
2015-01-18 20:02   ` [PATCH[V2] 2/5] tzset.3: First TZ specification clarification JWP
     [not found]     ` <54BC1172.5060100-KK0ffGbhmjU@public.gmane.org>
2015-01-25 14:10       ` Michael Kerrisk (man-pages)
2015-01-18 20:04   ` [PATCH[V2] 3/5] tzset.3: correct system timezone file path JWP
     [not found]     ` <54BC11E2.9020906-KK0ffGbhmjU@public.gmane.org>
2015-01-25 14:11       ` Michael Kerrisk (man-pages)
2015-01-18 20:07   ` [PATCH[V2] 4/5] tzset.3: Add Environment section JWP
     [not found]     ` <54BC126E.1080904-KK0ffGbhmjU@public.gmane.org>
2015-01-25 14:12       ` Michael Kerrisk (man-pages)
     [not found]         ` <54C4F9E7.6090104-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-28 23:52           ` JWP
2015-01-29  0:09           ` [PATCH V3 1/1] " J William Piggott
     [not found]             ` <54C97A2D.2050908-KK0ffGbhmjU@public.gmane.org>
2015-01-29  5:50               ` Michael Kerrisk (man-pages)
     [not found]                 ` <54C9CA11.207-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-29 16:27                   ` [PATCH V4 " J William Piggott
     [not found]                     ` <54CA5F5B.7070405-KK0ffGbhmjU@public.gmane.org>
2015-01-30  6:04                       ` Michael Kerrisk (man-pages)
2015-01-29  0:13           ` [PATCH 1/1] tzset.3: Add description for posixrules file J William Piggott
     [not found]             ` <54C97B45.2070300-KK0ffGbhmjU@public.gmane.org>
2015-01-29  5:51               ` Michael Kerrisk (man-pages) [this message]
     [not found]                 ` <54C9CA67.4080009-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-29 16:31                   ` [PATCH V2 " J William Piggott
     [not found]                     ` <54CA604A.1050500-KK0ffGbhmjU@public.gmane.org>
2015-01-30  6:04                       ` Michael Kerrisk (man-pages)
2015-01-18 20:10   ` [PATCH[V2] 5/5] tzset.3: TZ filespec omitts the colon JWP
     [not found]     ` <54BC132A.8090504-KK0ffGbhmjU@public.gmane.org>
2015-01-25 14:11       ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C9CA67.4080009@gmail.com \
    --to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=elseifthen-KK0ffGbhmjU@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.