All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Oded Gabbay <oded.gabbay@amd.com>,
	Alex Deucher <alexdeucher@gmail.com>,
	dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/radeon: don't init gpuvm if accel is disabled
Date: Thu, 29 Jan 2015 11:36:17 +0100	[thread overview]
Message-ID: <54CA0D21.1040907@vodafone.de> (raw)
In-Reply-To: <54C9E555.5090307@amd.com>

Am 29.01.2015 um 08:46 schrieb Oded Gabbay:
>
>
> On 01/28/2015 09:41 PM, Alex Deucher wrote:
>> If acceleration is disabled, it does not make sense
>> to init gpuvm since nothing will use it.  Moreover,
>> if radeon_vm_init() gets called it uses accel to try
>> and clear the pde tables, etc. which results in a bug.
>>
>> Bug:
>> https://bugs.freedesktop.org/show_bug.cgi?id=88786
>>
>> Signed-off-by: Alex Deucher<alexander.deucher@amd.com>
>> Cc:stable@vger.kernel.org

Patch is Reviewed-by: Christian König <christian.koenig@amd.com>

> Alex,
> What is accel ?
> Is there a situation where accel is disabled and HSA should work ? 
> e.g. headless mode ?

Not really.

Acceleration is disabled mostly because the user forgotten to install 
the firmware or we have a rather big bug in the driver and can't get the 
CP running.

In that case we still try to provide mode setting to get an error 
message on the screen, but everything else won't work.

Regards,
Christian.


>
> If so, we need gpuvm for local memory.
>
>     Oded
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-01-29 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 19:41 [PATCH] drm/radeon: don't init gpuvm if accel is disabled Alex Deucher
2015-01-29  7:46 ` Oded Gabbay
2015-01-29 10:36   ` Christian König [this message]
2015-01-29 13:54   ` Deucher, Alexander
2015-01-29 13:58     ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CA0D21.1040907@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=oded.gabbay@amd.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.