From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGopR-00025S-VH for qemu-devel@nongnu.org; Thu, 29 Jan 2015 08:08:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGopO-0006Zd-HJ for qemu-devel@nongnu.org; Thu, 29 Jan 2015 08:08:13 -0500 Message-ID: <54CA30B6.6040607@suse.de> Date: Thu, 29 Jan 2015 14:08:06 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1422507898-4348-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1422507898-4348-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] spapr_vio/spapr_iommu: Move VIO bypass where it belongs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, David Gibson On 29.01.15 06:04, Alexey Kardashevskiy wrote: > Instead of tweaking a TCE table device by adding there a bypass flag, > let's add an alias to RAM and IOMMU memory region, and enable/disable > those according to the selected bypass mode. > This way IOMMU memory region can have size of the actual window rather > than ram_size which is essential for upcoming DDW support. > > This moves bypass logic to VIO layer and keeps @bypass flag in TCE table > for migration compatibility only. This replaces spapr_tce_set_bypass() > calls with explicit assignment to avoid confusion as the function could > do something more that just syncing the @bypass flag. > > This adds a pointer to VIO device into the sPAPRTCETable struct to provide > the sPAPRTCETable device a way to update bypass mode for the VIO device. > > Signed-off-by: Alexey Kardashevskiy Thanks, applied to ppc-next. Alex